Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary shrink-to-fit=no meta data #6669

Merged
merged 1 commit into from Mar 18, 2019

Conversation

@abdelrahmanrifai
Copy link
Contributor

commented Mar 17, 2019

I was trying to understand the needs for shrink-to-fit=no meta data when I saw it in index.html file, after some testing myself and googling I came to a conclusion that it's no longer needed.

Removed recently from twbs/bootstrap/pull/28314, h5bp/html5-boilerplate#2102 and joshbuchea/HEAD@851bb66

More info in @scottaohara blogpost

@facebook-github-bot

This comment has been minimized.

Copy link

commented Mar 17, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Mar 17, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@petetnt
Copy link
Collaborator

left a comment

Seems that >iOS9.2 usage is negligible so I think we should be able to remove this safely

@iansu iansu added this to In progress in v3 via automation Mar 18, 2019

@iansu iansu added this to the 3.0 milestone Mar 18, 2019

@iansu iansu merged commit c5087e6 into facebook:master Mar 18, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Mar 18, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

Thanks!

@abdelrahmanrifai abdelrahmanrifai deleted the abdelrahmanrifai:remove-shrink-to-fit branch Mar 18, 2019

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.