Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate url key in siteConfig #6690

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@charpeni
Copy link
Contributor

commented Mar 20, 2019

url was duplicated in siteConfig.js, both were the same value, so stripping one of them.

@charpeni charpeni requested review from amyrlam and iansu as code owners Mar 20, 2019

@iansu iansu merged commit a1f6397 into facebook:master Mar 21, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

@iansu iansu added the tag: internal label Mar 21, 2019

@iansu iansu added this to the 3.0 milestone Mar 21, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

Good catch. Thanks!

@charpeni charpeni deleted the charpeni:patch-1 branch Mar 25, 2019

@lock lock bot locked and limited conversation to collaborators Mar 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.