Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Render deployment section #6695

Merged
merged 1 commit into from Apr 8, 2019

Conversation

@anurag
Copy link
Contributor

commented Mar 20, 2019

Screenshot:

image

@anurag anurag requested review from amyrlam and iansu as code owners Mar 20, 2019

@facebook-github-bot

This comment has been minimized.

Copy link

commented Mar 20, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Mar 20, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@amyrlam amyrlam force-pushed the facebook:master branch from cecd762 to d3b19f9 Mar 24, 2019

@anurag

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Additional context: Render serves over 7 million requests/day as of late March 2019.

@anurag

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

If it helps, here's the Render deployment section on Gatsby: https://www.gatsbyjs.org/docs/deploying-to-render/

@amyrlam amyrlam self-assigned this Apr 8, 2019

@petetnt

petetnt approved these changes Apr 8, 2019

Copy link
Collaborator

left a comment

LGTM

@amyrlam amyrlam added this to the 3.0 milestone Apr 8, 2019

@amyrlam amyrlam merged commit a1d6aef into facebook:master Apr 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
@anurag

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@amyrlam

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2019

thanks for the PR! 💯

@anurag anurag deleted the anurag:ag/render branch Apr 8, 2019

@lock lock bot locked and limited conversation to collaborators Apr 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.