Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill verdaccio in CI tasks cleanup #6700

Conversation

@santoshyadav198613
Copy link
Contributor

commented Mar 21, 2019

Fixes #6663.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Mar 21, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Mar 21, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:bug--Kill-verdaccio-in-CI-tasks-cleanup branch from 324efaf to 25339b4 Mar 21, 2019

@ianschmitz ianschmitz changed the title bug: Kill verdaccio in CI tasks cleanup Kill verdaccio in CI tasks cleanup Mar 22, 2019

@ianschmitz

This comment has been minimized.

Copy link
Collaborator

commented Mar 22, 2019

Looks like that worked!

https://travis-ci.org/facebook/create-react-app/jobs/509467770#L1827

Can you update our other e2e scripts that use verdaccio with the same cleanup logic?

@ianschmitz ianschmitz self-assigned this Mar 22, 2019

@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:bug--Kill-verdaccio-in-CI-tasks-cleanup branch from 25339b4 to a6811f1 Mar 22, 2019

@santoshyadav198613

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

Looks like that worked!

https://travis-ci.org/facebook/create-react-app/jobs/509467770#L1827

Can you update our other e2e scripts that use verdaccio with the same cleanup logic?

Done, waiting for build.

@santoshyadav198613

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@ianschmitz ,
The changes worked for other task as well. Let me know if we need any other changes.

Show resolved Hide resolved tasks/e2e-old-node.sh Outdated

@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:bug--Kill-verdaccio-in-CI-tasks-cleanup branch from a6811f1 to 24d0bfd Mar 22, 2019

@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:bug--Kill-verdaccio-in-CI-tasks-cleanup branch from 24d0bfd to 50f29f7 Mar 22, 2019

@amyrlam amyrlam force-pushed the facebook:master branch from cecd762 to d3b19f9 Mar 24, 2019

@santoshyadav198613

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Hi @ianschmitz ,

Let me know if any changes are needed.

@ianschmitz ianschmitz added this to the 3.0 milestone Mar 26, 2019

@ianschmitz ianschmitz merged commit 5acb286 into facebook:master Mar 26, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
@ianschmitz

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

Looks good. Thanks @santoshyadav198613

@lock lock bot locked and limited conversation to collaborators Mar 31, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.