Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project property from @typescript-eslint/parser options #6701

Merged
merged 2 commits into from Mar 29, 2019

Conversation

@jackwilsdon
Copy link
Contributor

commented Mar 21, 2019

The "project" property has a significant performance impact on linting,
and none our rules currently need it.

Fixes #6661.

@ianschmitz

This comment has been minimized.

Copy link
Collaborator

commented Mar 22, 2019

We also have logic at the top of this file that is specific to the typescript project settings:

// The following is copied from `react-scripts/config/paths.js`.
const path = require('path');
const fs = require('fs');
// Make sure any symlinks in the project folder are resolved:
// https://github.com/facebook/create-react-app/issues/637
const appDirectory = fs.realpathSync(process.cwd());
const resolveApp = relativePath => path.resolve(appDirectory, relativePath);
const projectRootPath = resolveApp('.');
const tsConfigPath = resolveApp('tsconfig.json');
.

@ianschmitz ianschmitz added this to In progress in v3 via automation Mar 22, 2019

@ianschmitz ianschmitz added this to the 3.0 milestone Mar 22, 2019

Remove project property from @typescript-eslint/parser options
The "project" property has a significant performance impact on linting,
and none our rules currently need it.

Fixes #6661.
@jackwilsdon

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

Oops, missed those! I've removed them now 👍

@ianschmitz

This comment has been minimized.

Copy link
Collaborator

commented Mar 24, 2019

I removed some unnecessary code that was added for the project setting.

@jackwilsdon

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2019

Oops, missed those too 😖 cheers

@amyrlam amyrlam force-pushed the facebook:master branch from cecd762 to d3b19f9 Mar 24, 2019

@ianschmitz ianschmitz merged commit 1a61db5 into facebook:master Mar 29, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Mar 29, 2019

Idered added a commit to eyedea-io/create-react-app that referenced this pull request Apr 1, 2019

Merge pull request #1 from facebook/master
Remove project property from @typescript-eslint/parser options (facebook#6701)

@lock lock bot locked and limited conversation to collaborators Apr 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.