Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change NODE_ENV and PUBLIC_URL into readonly #6750

Merged
merged 1 commit into from Apr 7, 2019

Conversation

@xiaoxiangmoe
Copy link
Contributor

commented Apr 4, 2019

after change it

process.env.NODE_ENV = 'development'

will throw

Cannot assign to 'NODE_ENV' because it is a read-only property.ts(2540)
@mrmckeb

mrmckeb approved these changes Apr 7, 2019

Copy link
Collaborator

left a comment

Great idea, @xiaoxiangmoe. Let's get this one in!

@mrmckeb

This comment has been minimized.

Copy link
Collaborator

commented Apr 7, 2019

@xiaoxiangmoe - can you please rebase from master and see if that fixes your tests, I'm assuming it will. I know the tests failures are unrelated, but I think we should make sure they're passing regardless.

CC @iansu @ianschmitz

@mrmckeb mrmckeb merged commit ebabd18 into facebook:master Apr 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
@mrmckeb

This comment has been minimized.

Copy link
Collaborator

commented Apr 7, 2019

Thanks again, @xiaoxiangmoe

@lock lock bot locked and limited conversation to collaborators Apr 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.