Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netbeans to the list #6763

Open
wants to merge 1 commit into
base: master
from

Conversation

@ferrybig
Copy link

ferrybig commented Apr 5, 2019

According to the documentation, you can specify a line number using file:number syntax: http://wiki.netbeans.org/FaqCliOpen

netbeans Something.java:55

According to the instructions at https://facebook.github.io/create-react-app/docs/advanced-configuration I need to list my editor at this list detect it, no further testing instructions have been provided

EDIT: At the moment, the Netbeans editor works when placing a shortcut inside /usr/local/bin to Netbeans, and then starting the devserver using REACT_EDITOR=netbeans npm run serve, but I cant find any documentation on how to make a test version of this package so I can actually test the integration

Add netbeans to the list
According to the documentation, you can specify a line number using file:number syntax: http://wiki.netbeans.org/FaqCliOpen

> `netbeans Something.java:55`
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Apr 5, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@iansu iansu self-assigned this Apr 5, 2019

@bugzpodder

This comment has been minimized.

Copy link
Collaborator

bugzpodder commented Apr 7, 2019

@ferrybig you can just edit this file in your node_modules folder and test it this way. Just make sure you find the right one:
either <project_dir>/node_modules/react-scripts/node_modules/react-dev-utils/launch_editor.js or
<project_dir>/node_modules/react-dev-utils/launch_editor.js

@ferrybig

This comment has been minimized.

Copy link
Author

ferrybig commented Apr 9, 2019

@bugzpodder I was able to fully test my change, and it worked. When clicking the error message in react, netbeans 11 opened the file on the line specified

Example of this working on Netbeans 11 on Ubuntu:

Screenshot from 2019-04-09 15-22-20

Note that I find this change to the project a trivial change, its just copy and pasting some line after basically following some instructions. And thus no copyright can fall on the change itself, and thus no copyright have to be exchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.