Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused babel-loader from babel-preset-react-app #6780

Merged

Conversation

@tlrobinson
Copy link
Contributor

commented Apr 9, 2019

As far as I can tell there's no reason for the webpack babel-loader to be a dependency of babel-preset-react-app. If you happen to use babel-preset-react-app without Webpack you get a warning like

warning "babel-preset-react-app > babel-loader@8.0.5" has unmet peer dependency "webpack@>=2".

There was another PR #6124 but it wasn't merged for some reason.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 9, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 9, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 3.0 milestone Apr 9, 2019

@ianschmitz ianschmitz merged commit b676bf3 into facebook:master Apr 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
@ianschmitz

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Apr 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.