Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CRA version in `react-scripts` eject warning. #6845

Merged
merged 2 commits into from Apr 19, 2019

Conversation

@lffg
Copy link
Contributor

commented Apr 18, 2019

Fixes #6838.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 18, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 18, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Apr 18, 2019

I think we probably want to say something like Create React App 2+ or Create React App 2 and above.

@iansu iansu self-assigned this Apr 18, 2019

@iansu iansu added this to In progress in v3 via automation Apr 18, 2019

@iansu iansu added this to the 3.0 milestone Apr 18, 2019

@lffg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

Fixed, @iansu.

@iansu iansu merged commit 022b984 into facebook:master Apr 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Apr 19, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2019

Thanks!

@lffg lffg deleted the lffg-forks:patch-1 branch Apr 19, 2019

@lock lock bot locked and limited conversation to collaborators Apr 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.