Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-watch flag in favor of watchAll=false #6848

Merged
merged 1 commit into from Apr 19, 2019

Conversation

@bugzpodder
Copy link
Collaborator

commented Apr 19, 2019

yarn test --watchAll=false or npm test -- --watchAll=false is already sufficient for running tests in non-watch mode. Both does the same thing as the current --no-watch flag.

@bugzpodder

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 19, 2019

@mrmckeb

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2019

While this is true, I feel like having to set pass a flag as false feels counter-intuitive... like having to set a boolean prop to false in React.

If the rest of the team are in favour of this, I think this should be in 3.0.

@mrmckeb mrmckeb added this to the 3.0 milestone Apr 19, 2019

@mrmckeb mrmckeb merged commit 200b98b into facebook:master Apr 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

@lock lock bot locked and limited conversation to collaborators Apr 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.