Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `Object.assign` from `MiniCssExtractPlugin` options #6854

Merged
merged 1 commit into from Apr 29, 2019

Conversation

@swashcap
Copy link
Contributor

commented Apr 19, 2019

馃憢 Hello! I'm reading through react-scripts' Webpack configuration to learn a little bit more about Webpack. Thanks for the ample comments! It's super helpful.

I noticed this unneeded Object.assign in a .css loader's options, so thought I'd remove it.

  • Problem: Using Object.assign in shouldUseRelativeAssetPaths falsey case adds a lil bit of an unneeded function call
  • Solution: Remove Object.assign and add {} to the ternary false expression
  • Testing: ?
@Timer

Timer approved these changes Apr 29, 2019

@iansu iansu added the tag: internal label Apr 29, 2019

@iansu iansu added this to the 3.0.1 milestone Apr 29, 2019

@iansu iansu merged commit a2ae8a7 into facebook:master Apr 29, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
@iansu

This comment has been minimized.

Copy link
Collaborator

commented Apr 29, 2019

Thanks!

@swashcap swashcap deleted the swashcap:fix-remove-unneeded-object-assign branch Apr 29, 2019

@lock lock bot locked and limited conversation to collaborators May 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can鈥檛 perform that action at this time.