Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cssmodule classname hash to use repo relative paths instead of… #6876

Merged

Conversation

@vg-stan
Copy link
Contributor

commented Apr 23, 2019

Fixes #6875.

I tested this using two clones of a project using CRA and css modules. The clones have different paths. Before this PR, the classname hashes would be different, after the change the classnames are the same.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 23, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

switch to using path.posix.relative instead of string replace for
project relative paths used in css module hashing
@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 27, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 3.0.1 milestone Apr 28, 2019

@ianschmitz ianschmitz merged commit c80e3fe into facebook:master Apr 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
@ianschmitz

This comment has been minimized.

Copy link
Collaborator

commented Apr 28, 2019

Thanks. Great first contribution!

@lock lock bot locked and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.