Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GraphQL doc #6898

Merged
merged 2 commits into from Apr 30, 2019

Conversation

@nagman
Copy link
Contributor

commented Apr 25, 2019

A few corrections on the graphql docs, because it doesn't work without installing the graphql package, and you need to provide real graphql in the .graphql file, not gql wrapped graphql.

nagman added some commits Apr 25, 2019

Merge pull request #1 from nagman/nagman-patch-1
Update loading-graphql-files.md

@nagman nagman requested review from amyrlam and iansu as code owners Apr 25, 2019

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 25, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 25, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@amyrlam amyrlam self-assigned this Apr 26, 2019

@petetnt
Copy link
Collaborator

left a comment

LGTM! Thanks for these!

@amyrlam amyrlam changed the title graphql doc update Update GraphQL doc Apr 30, 2019

@amyrlam amyrlam merged commit 4b8b38b into facebook:master Apr 30, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

@lock lock bot locked and limited conversation to collaborators May 5, 2019

@iansu iansu added this to the 3.0.1 milestone May 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.