Amend docs - "add typescript" global warning #6911
Conversation
Update loading-graphql-files.md
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
methodbox
changed the title
|
@methodbox looks good 👍 checked out the conversation on the linked issue. Can you remove the commits from nagman? |
|
Sure, I’ll take a look at this in the morning. |
| @@ -16,6 +16,7 @@ npx create-react-app my-app --typescript | |||
|
|
|||
| yarn create react-app my-app --typescript | |||
| ``` | |||
| > Note that having `create-react-app` installed globally can cause conflicts when using `--typescript`. If you've previously installed `create-react-app` globally via `npm install -g create-react-app`, we recommend you uninstall the package using `npm uninstall -g create-react-app` to ensure that `npx` always uses the latest version. | |||
There was a problem hiding this comment.
This first sentence is not accurate. Having Create React App installed globally doesn't create a "conflict" with the --typescript flag. It just means you're more likely to have an old version installed that doesn't have the --typescript flag. As the last sentence says, you should use npx instead of a global install to ensure you're using an up to date version of Create React App.
There was a problem hiding this comment.
I've made this change but I'm still not sure how to correctly remove the commits from @nagman.
I'm a bit confused by this; it looks like this commit has already been merged. Can you clarify? What is the best way to remove these commits? I've found this on Stackoverflow, but not sure: https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch |
|
I noticed that you forked from
It may be simplest to redo your fork from here https://github.com/facebook/create-react-app and submit a new PR. (That will also make it easier for you to submit PR's in the future with a synced fork.) Be sure to do the change that iansu mentioned, which will match what was discussed in #6816 (comment). |
Okay, oops! I'll resubmit as you said, forking from FB/CRA. |
|
I've created a corrected PR ... forked from the right location this time 🥇 Closing. |
Related to: #6816
Updating blockquote to advise on use of CRA globally vs. npx when using --typescript flag.