Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarifying note to TypeScript docs warning about global install of CRA #6945

Merged
merged 2 commits into from May 1, 2019

Conversation

@methodbox
Copy link
Contributor

commented Apr 28, 2019

Added block quote with warning about issues when CRA is installed globally.

Related to: #6816 & #6911

Updating blockquote to advise on use of CRA globally vs. npx when using --typescript flag.

amend-docs-adding-typescript
Added block quote with warning about issues when CRA is installed globally.

@amyrlam amyrlam added this to the 3.0.1 milestone Apr 28, 2019

@amyrlam amyrlam changed the title amend-docs-adding-typescript Add clarifying note to TypeScript docs warning about global install of CRA Apr 28, 2019

Update docusaurus/docs/adding-typescript.md
Co-Authored-By: methodbox <chris@methodbox.io>
@amyrlam
Copy link
Collaborator

left a comment

Thanks for fixing your fork and resubmitting! 🎉 Looks good to me, will let @iansu confirm.

@iansu

iansu approved these changes Apr 30, 2019

@amyrlam amyrlam merged commit 6710f52 into facebook:master May 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
@amyrlam

This comment has been minimized.

Copy link
Collaborator

commented May 1, 2019

I reworded the title too long with the PR number amended to end (#6945), will account for that in commit length next time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.