Skip to content

fix the hanging test in Jenkins. fix #6899 #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix the hanging test in Jenkins. fix #6899 #8365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4b88c4
fix the hanging test in Jenkins. fix #6899
iamstarkov Jan 23, 2020
bf85cb4
add is-ci as a devDependency to support #8365
iamstarkov Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"get-port": "^4.2.0",
"globby": "^9.1.0",
"husky": "^1.3.1",
"is-ci": "^2.0.0",
"jest": "24.9.0",
"lerna": "3.19.0",
"lerna-changelog": "~0.8.2",
Expand Down
3 changes: 2 additions & 1 deletion packages/react-scripts/scripts/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ verifyTypeScriptSetup();
// @remove-on-eject-end

const jest = require('jest');
const isCI = require('is-ci')
const execSync = require('child_process').execSync;
let argv = process.argv.slice(2);

Expand All @@ -56,7 +57,7 @@ function isInMercurialRepository() {

// Watch unless on CI or explicitly running all tests
if (
!process.env.CI &&
!isCI &&
argv.indexOf('--watchAll') === -1 &&
argv.indexOf('--watchAll=false') === -1
) {
Expand Down