feat(v2): add cache-loader by default especially on babel-loader#1335
Merged
Conversation
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit a658d67 |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit a658d67 |
yangshun
approved these changes
Apr 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add https://github.com/webpack-contrib/cache-loader/ by default especially on expensive loader like babel-loader.
Also add
--no-cache-loadercli option if user don't want it.How it works:
Caches the result of following loaders on disk
See test plan for benefits
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Yarn start
With cache-loader. Subsequent build is faster due to reuse of cache
Without cache loader, roughly similar performance
Yarn build
With cache-loader
Without cache-loader
Notes:
Lot of possibility for improvement in the future. Just adding it for now