Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): minify css #1572

Merged
merged 2 commits into from Jun 6, 2019

Conversation

@endiliey
Copy link
Collaborator

commented Jun 6, 2019

Motivation

Minify css with https://github.com/NMFR/optimize-css-assets-webpack-plugin

Under the hood it uses cssnano

extra:
minor refactoring on prefetch preload logic to increase web performance

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

before
unminified

after
minified

@endiliey endiliey requested a review from yangshun as a code owner Jun 6, 2019

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Deploy preview for docusaurus-2 ready!

Built with commit af6b1b4

https://deploy-preview-1572--docusaurus-2.netlify.com

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Deploy preview for docusaurus-preview ready!

Built with commit af6b1b4

https://deploy-preview-1572--docusaurus-preview.netlify.com

@endiliey endiliey merged commit f07791b into master Jun 6, 2019

3 checks passed

ci/circleci: lint-prettier Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@endiliey endiliey deleted the endiliey/minify-css branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.