feat(v2): @docusaurus/plugin-ideal-image #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 2c2c5c6 |
|
Deploy preview for docusaurus-preview ready! Built with commit 2c2c5c6 |
endiliey
commented
Jul 17, 2019
| @@ -14,14 +14,14 @@ function Image(props) { | |||
| {...props} | |||
| alt={alt} | |||
| className={className} | |||
| height={img.src.height} | |||
| height={img.src.height || 100} | |||
There was a problem hiding this comment.
in case someone wonders the hardcoded 100 value.
This is just to not throw error in dev because height and weight is a required field for react-ideal-image
see https://github.com/endiliey/responsive-loader#options
Disable processing of images by this loader (useful in development). srcSet and other attributes will still be generated but only for the original size. Note that the width and height attributes will both be set to 100 but the image will retain its original dimensions.
endiliey
commented
Jul 17, 2019
| <div class="avatar__intro margin-left--none"> | ||
| <h4 class="avatar__name">{user.title}</h4> | ||
| <small class="avatar__subtitle"> | ||
| <div className="avatar"> |
There was a problem hiding this comment.
fix class -> className
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Docusaurus Plugin to generate an almost ideal image (responsive, lazy-loading, and low quality placeholder)
Close #928
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Lazy loading and blurred placeholder
Generate no of responsive images depends on option
doesnt emit twice on client n server
https://github.com/endiliey/responsive-loader
The fork also had passing test case, original test cases are failing