Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): SEO #1677

Merged
merged 4 commits into from Jul 20, 2019

Conversation

@wgao19
Copy link
Collaborator

commented Jul 19, 2019

Motivation

Addressing #1640, refactor & improve docs for SEO

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

wgao19 added some commits Jul 19, 2019

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 0758cbb

https://deploy-preview-1677--docusaurus-2.netlify.com

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 0758cbb

https://deploy-preview-1677--docusaurus-preview.netlify.com

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Deploy preview for docusaurus-2 ready!

Built with commit e0dca1b

https://deploy-preview-1677--docusaurus-2.netlify.com

@wgao19 wgao19 referenced this pull request Jul 19, 2019
12 of 19 tasks complete
@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Deploy preview for docusaurus-preview ready!

Built with commit e0dca1b

https://deploy-preview-1677--docusaurus-preview.netlify.com

@endiliey
Copy link
Collaborator

left a comment

lgtm

@yangshun
Copy link
Member

left a comment

What's the rationale behind changing to "Reaching Users"? SEO sounds more obvious to me.

LGTM, just nits!

import Head from '@docusaurus/HEAD';
const MySEO = () => (
<React.Fragment>

This comment has been minimized.

Copy link
@yangshun

yangshun Jul 19, 2019

Member

Why not use <>?

This comment has been minimized.

Copy link
@wgao19

wgao19 Jul 20, 2019

Author Collaborator

Updated 🦖

keywords:
- docs
- docusaurus
description: 'How do I find you when I cannot solve this problem'

This comment has been minimized.

Copy link
@yangshun

yangshun Jul 19, 2019

Member

I don't think yaml needs quotes.

* The following fields are used for `og:image` and `twitter:image`
*/
baseUrl: '/',
siteUrl: 'https://docusaurus.io/',

This comment has been minimized.

Copy link
@yangshun

yangshun Jul 19, 2019

Member

Don't need trailing slash

To add customized SEO, use the `Head` component from `@docusaurus/HEAD`.

```js
import Head from '@docusaurus/HEAD';

This comment has been minimized.

Copy link
@yangshun

yangshun Jul 19, 2019

Member

@docusaurus/Head


### Customize SEO

To add customized SEO, use the `Head` component from `@docusaurus/HEAD`.

This comment has been minimized.

Copy link
@yangshun

yangshun Jul 19, 2019

Member

@docusaurus/Head

@wgao19 wgao19 merged commit 2a1eb36 into master Jul 20, 2019

4 checks passed

ci/circleci: lint-prettier Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
netlify/docusaurus-2/deploy-preview Deploy preview ready!
Details

@endiliey endiliey deleted the wgao19/docs-seo branch Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.