Skip to content

refactor(v2): use forked lqip-loader for performance - #1680

Merged
endiliey merged 1 commit into
masterfrom
endiliey/refactor-lqip
Jul 20, 2019
Merged

endiliey merged 1 commit into
masterfrom
endiliey/refactor-lqip

Conversation

@endiliey

@endiliey endiliey commented Jul 20, 2019 •

Copy link
Copy Markdown
Contributor

Motivation

I forked https://github.com/zouhir/lqip-loader to https://github.com/endiliey/lqip-loader because the original version uses jimp, which is an image processing library that is so much slower than sharp

Check this benchmark for jimp vs sharp
https://sharp.pixelplumbing.com/en/stable/performance/

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

  • even in dev 1s is gained

before
before

after
after

  • no changes in placeholder generation. check netlify

before in prod

before-prod

after in prod
after-prod

@endiliey
endiliey requested a review from yangshun as a code owner July 20, 2019 08:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 20, 2019
@docusaurus-bot

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit fa9c0c8

https://deploy-preview-1680--docusaurus-2.netlify.com

@docusaurus-bot

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit fa9c0c8

https://deploy-preview-1680--docusaurus-preview.netlify.com

@endiliey
endiliey merged commit 7f5c1ef into master Jul 20, 2019
@endiliey
endiliey deleted the endiliey/refactor-lqip branch July 20, 2019 08:27
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants