Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): use forked lqip-loader for performance #1680

Merged
merged 1 commit into from
Jul 20, 2019

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Jul 20, 2019

Motivation

I forked https://github.com/zouhir/lqip-loader to https://github.com/endiliey/lqip-loader because the original version uses jimp, which is an image processing library that is so much slower than sharp

Check this benchmark for jimp vs sharp
https://sharp.pixelplumbing.com/en/stable/performance/

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

  • even in dev 1s is gained

before
before

after
after

  • no changes in placeholder generation. check netlify

before in prod

before-prod

after in prod
after-prod

@endiliey endiliey requested a review from yangshun as a code owner July 20, 2019 08:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 20, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit fa9c0c8

https://deploy-preview-1680--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit fa9c0c8

https://deploy-preview-1680--docusaurus-preview.netlify.com

@endiliey endiliey merged commit 7f5c1ef into master Jul 20, 2019
@endiliey endiliey deleted the endiliey/refactor-lqip branch July 20, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants