Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v1): showcase user collective #1998

Merged
merged 1 commit into from Nov 15, 2019
Merged

docs(v1): showcase user collective #1998

merged 1 commit into from Nov 15, 2019

Conversation

kenning
Copy link
Contributor

@kenning kenning commented Nov 15, 2019

Adds my site as a collaborator. I asked endiliey about it here: #1437 (comment)

@facebook-github-bot
Copy link
Contributor

Hi kenning! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Hi kenning! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 1d415b7

https://deploy-preview-1998--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 1d415b7

https://deploy-preview-1998--docusaurus-preview.netlify.com

yangshun
yangshun approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is cool!

@yangshun yangshun changed the title docs: showcase user collective docs(v1): showcase user collective Nov 15, 2019
@yangshun yangshun merged commit a65a57b into facebook:master Nov 15, 2019
@kenning
Copy link
Contributor Author

kenning commented Nov 15, 2019

Thanks 😄 you should sign up

@endiliey
Copy link
Contributor

ok maybe time to play this and stop contributing to docusaurus 😂

@endiliey endiliey added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

@endiliey endiliey Awaiting requested review from endiliey

Assignees
No one assigned
Labels
pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kenning @facebook-github-bot @docusaurus-bot @endiliey @yangshun