Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): include appId key for Algolia #2413

Merged
merged 4 commits into from Mar 17, 2020
Merged

Conversation

@TheodoreChu
Copy link
Contributor

TheodoreChu commented Mar 15, 2020

appId is needed for self-hosted Docsearch

Motivation

Update Algolia information. The information is similar for v1: https://docusaurus.io/docs/en/site-config.html#algolia-object

Have you read the Contributing Guidelines on pull requests?

Not yet

Test Plan

I used it on my personal site

Related PRs

None

appId is needed for self-hosted Docsearch
@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

docusaurus-bot commented Mar 15, 2020

Deploy preview for docusaurus-2 ready!

Built with commit a42c1cb

https://deploy-preview-2413--docusaurus-2.netlify.com

Copy link
Collaborator

lex111 left a comment

Good catch, but could you please reflect this change in other versions of docs?

TheodoreChu added 2 commits Mar 16, 2020
@TheodoreChu TheodoreChu changed the title Update Algolia information Update Algolia information for alpha.43 Mar 16, 2020
@TheodoreChu TheodoreChu changed the title Update Algolia information for alpha.43 Update Algolia information Mar 16, 2020
@TheodoreChu

This comment has been minimized.

Copy link
Contributor Author

TheodoreChu commented Mar 16, 2020

OK, I updated the information for alpha.40, alpha.43, and alpha.48

@lex111 lex111 requested a review from wgao19 as a code owner Mar 17, 2020
@lex111 lex111 changed the title Update Algolia information docs(v2): include appId key for Algolia Mar 17, 2020
@lex111
lex111 approved these changes Mar 17, 2020
@lex111 lex111 merged commit 99943a6 into facebook:master Mar 17, 2020
2 of 4 checks passed
2 of 4 checks passed
build (10.x)
Details
ci/circleci: tests CircleCI is running your tests
Details
deploy/netlify Deploy preview processing.
Details
ci/circleci: lint-prettier Your tests passed on CircleCI!
Details
@lex111

This comment has been minimized.

Copy link
Collaborator

lex111 commented Mar 17, 2020

@TheodoreChu thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.