Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add FoalTS to showcase page #3928

Merged
merged 1 commit into from
Dec 16, 2020
Merged

docs(v2): add FoalTS to showcase page #3928

merged 1 commit into from
Dec 16, 2020

Conversation

LoicPoullain
Copy link
Contributor

Motivation

The documentation of FoalTS has migrated from Gitbook to Docusaurus v2. It could be great to add it in the showcase page.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.

Related PRs

No docs to update.

@facebook-github-bot
Copy link
Contributor

Hi @LoicPoullain!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@LoicPoullain LoicPoullain changed the title docs: add FoalTS to showcase page docs(v2): add FoalTS to showcase page Dec 16, 2020
@github-actions
Copy link

Size Change: +19 B (0%)

Total Size: 152 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.8 kB -1 B
website/build/main.********.js 108 kB +20 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Dec 16, 2020

✔️ Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

🔨 Explore the source changes: 898e07f

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fda1eb3922867000793dfb9

😎 Browse the preview: https://deploy-preview-3928--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 86
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3928--docusaurus-2.netlify.app/classic/

@slorber
Copy link
Collaborator

slorber commented Dec 16, 2020

Thanks @LoicPoullain , that looks great

can you sign the CLA please? I can't merge without it

@LoicPoullain
Copy link
Contributor Author

Hmm, this is weird. I signed it 10-15minutes. I'll try again.

@LoicPoullain
Copy link
Contributor Author

I've signed again. Maybe there's a lot of traffic now.

If you already submitted a pull request before signing the CLA, then we will add a confirmation comment on that pull request (this might take several minutes).

@slorber
Copy link
Collaborator

slorber commented Dec 16, 2020

yes sometimes the bot takes time :) will wait and see thanks

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 16, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 16, 2020
@slorber slorber merged commit 57c336c into facebook:master Dec 16, 2020
@LoicPoullain LoicPoullain deleted the add-foal-to-showcase branch December 16, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants