Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add overwriting css variables for dark mode #3991

Merged
merged 1 commit into from Jan 4, 2021

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Jan 4, 2021

Motivation

When I wanted to change the css variables used in dark mode I struggle a bit to figure out how.

Have you read the Contributing Guidelines on pull requests?

yep

Test Plan

I ran:
yarn test
yarn test:build:v2

Closes #3985

@facebook-github-bot
Copy link
Contributor

Hi @natac13!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Jan 4, 2021

✔️ Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9e26d79

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ff352472e3b1f0008b2b691

😎 Browse the preview: https://deploy-preview-3991--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 95
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3991--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

Size Change: +5 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB -1 B (0%)
website/build/main.********.js 112 kB +7 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 4, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 4, 2021
@slorber
Copy link
Collaborator

slorber commented Jan 4, 2021

thanks 😄

@slorber slorber changed the title docs: add overwriting css variables for dark mode docs(v2): add overwriting css variables for dark mode Jan 4, 2021
@slorber slorber merged commit da23912 into facebook:master Jan 4, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to have different Color with Dark mode
4 participants