Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix minor a11y issues #4906

Merged
merged 1 commit into from Jun 9, 2021
Merged

fix(v2): fix minor a11y issues #4906

merged 1 commit into from Jun 9, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 4, 2021

Motivation

Fix minor errors related with a11y which reported by Rocket Validator:

  • The element “input” must not appear as a descendant of an element with the attribute “role=button” (Toggle)
  • Possible misuse of “aria-label” (Showcase)
  • Select element must have an accessible name (Showcase)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Jun 4, 2021
@lex111 lex111 requested a review from slorber as a code owner June 4, 2021 11:48
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 4, 2021
@netlify
Copy link

netlify bot commented Jun 4, 2021

✔️ [V2]

🔨 Explore the source changes: 0c703b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60ba222c192b180008b43677

😎 Browse the preview: https://deploy-preview-4906--docusaurus-2.netlify.app

@netlify
Copy link

netlify bot commented Jun 4, 2021

✔️ [V1]

🔨 Explore the source changes: 0c703b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60ba222c7a3dea0009ead4ca

😎 Browse the preview: https://deploy-preview-4906--docusaurus-1.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 56
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4906--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Size Change: 0 B

Total Size: 621 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 88.3 kB 0 B
website/build/assets/js/main.********.js 443 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 27.1 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jun 9, 2021

👍

@slorber slorber merged commit 869f4bf into master Jun 9, 2021
@slorber slorber deleted the lex111/a11y-issues branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants