Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v2): add easyjwt to users #5177

Merged
merged 2 commits into from Jul 16, 2021
Merged

docs(v2): add easyjwt to users #5177

merged 2 commits into from Jul 16, 2021

Conversation

dbrrt
Copy link
Contributor

@dbrrt dbrrt commented Jul 15, 2021

Motivation
Adding easyjwt project to the showcase/users section.

Have you read the Contributing Guidelines on pull requests?
Yes

Test Plan
Starting the website should display Easyjwt in the showcase part, including easyjwt.png preview.

Related PRs
N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 15, 2021
@netlify
Copy link

netlify bot commented Jul 15, 2021 •
edited

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 4f949f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60f1941d3445c90007a589a0

😎 Browse the preview: https://deploy-preview-5177--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jul 15, 2021 •
edited

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5177--docusaurus-2.netlify.app/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 15, 2021
slorber
slorber approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Your site's url does not work without www (or it does but not reliably or very slow, particularly in a new browser session.

Should we change that?

website/src/data/users.js Outdated Show resolved Hide resolved
@dbrrt @slorber
Update website/src/data/users.js
4f949f9 
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
@dbrrt
Copy link
Contributor Author

dbrrt commented Jul 16, 2021

@slorber Good catch, www. was indeed missing.

@slorber slorber merged commit 6210509 into facebook:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber slorber approved these changes

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbrrt @slorber @facebook-github-bot