Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove unnecessary semicolon #7000

Merged
merged 2 commits into from Mar 25, 2022
Merged

docs: remove unnecessary semicolon #7000

merged 2 commits into from Mar 25, 2022

Conversation

imsingh
Copy link
Contributor

@imsingh imsingh commented Mar 25, 2022

Motivation

The semicolon after the TOCInline component is unnecessary and actually gets rendered on screen.

@imsingh
docs: remove unnecessary semicolon
452911e 
The semicolon after the TOCInline component is unnecessary and actually gets rendered on screen.
@facebook-github-bot
Copy link
Contributor

Hi @imsingh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 25, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@netlify
Copy link

netlify bot commented Mar 25, 2022

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 7a9d89e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623de52bdbfdd80008582f27
😎 Deploy Preview https://deploy-preview-7000--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 55
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7000--docusaurus-2.netlify.app/

Josh-Cena
Josh-Cena approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

That semicolon is automatically added by Prettier. I sometimes remember to prettier-ignore, other times can't be bothered😅

@Josh-Cena Josh-Cena merged commit 2dea99b into facebook:main Mar 25, 2022
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imsingh @facebook-github-bot @Josh-Cena