Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update static-site-generator-webpack-plugin #7547

Merged
merged 2 commits into from Jun 2, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 1, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Upgrade the dependency @slorber/static-site-generator-webpack-plugin after some cleanup and a few PRs merged

New concurrency option added with env variable. Not documented for now, looking for feedback before.

Test Plan

site builds fine, not slower than before

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

slorber/static-site-generator-webpack-plugin#2

slorber/static-site-generator-webpack-plugin#3

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 1, 2022
@netlify
Copy link

netlify bot commented Jun 1, 2022

[V2]

Name Link
🔨 Latest commit f1f87ff
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62986c436c0cfe0009a8dff1
😎 Deploy Preview https://deploy-preview-7547--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 47 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 82 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Size Change: 0 B

Total Size: 798 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.6 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 600 kB
website/build/index.html 38.9 kB

compressed-size-action

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy-ship-it

@Josh-Cena Josh-Cena added the domain: dependencies Proposal to upgrade a dependency across major versions label Jun 2, 2022
yarn.lock Outdated
cheerio "^0.22.0"
eval "^0.1.8"
webpack-sources "^1.4.3"
eval "^0.1.4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This range change looks a bit weird, though

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good catch, bad merge, will publish another version

@Josh-Cena
Copy link
Collaborator

Excited that we got rid of a bunch of lodash modules, bluebird, AND cheerio!

@slorber slorber merged commit 6afc902 into main Jun 2, 2022
@slorber slorber deleted the slorber/update-ssr-plugin branch June 2, 2022 08:09
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA domain: dependencies Proposal to upgrade a dependency across major versions pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants