-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(content-blog): make RSS feed generation work with slugs with .html extension #8158
Conversation
@slorber I've created a PR. Can you take a look. I've tried to cover all these points you've mentioned
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM 👍
Just fixed a edge case where the slug could contain .html
in other places than the end
…l extension (#8158) Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
Pre-flight checklist
Motivation
Before this commit, adding slugs ending in .html to the frontmatter blogs resulted in the build process breaking. This PR fixes this issue
Test Plan
Added Tests for the emitUtils.readOutputHTMLFile function in which the changes were to be made. Sample file also has been added in website/_dogfooding
Test links
Deploy preview: https://deploy-preview-8158--docusaurus-2.netlify.app/
Related issues/PRs
Closes #8139