-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): add more tag names to inline code element set #8190
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 816 kB ℹ️ View Unchanged
|
LGTM 👍 thanks Just to remember the context, is this only useful when using like |
Yep, which is why I still excluded some non-typographic tags. Bundle size phobia. Let's hope no one complains. |
For reference, with MDX 2.0 (PR: #8288) all the lower-case JSX elements (like This is now your responsibility to create/import your own Code component in case the default behavior of MDX 2.0 is not good for your use case. I think it should be good in most cases as it's just rendering the dom nodes as is, like the web behaves. The theme I'm removing the code to render elements inline anyway because fanced code blocks are never rendered inline. This if/else logic was added only to mitigate the fact it was not easy to distinguish between fenced code blocks and usage of |
Pre-flight checklist
b
,i
,s
, oru
tags are used withincode
tags #8189) and the maintainers have approved on my working plan.Motivation
I should have done this initially but was too lazy to. This list is adapted from https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_categories#phrasing_content
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs