-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-client-redirects): keep the query string + hash #8227
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thanks, LGTM 👍 Just added support for keeping the hash too + fixed a little client redirect bug on our own site Test URL: https://deploy-preview-8227--docusaurus-2.netlify.app/docs/introduction?qs=true#someHash Note: this assumes that the redirect URL does not already contain a query string already, which is likely to be the case but maybe we'll need to |
Thanks @slorber for the adjustments! 😉 |
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
Pre-flight checklist
Motivation
Closes #8206
Test Plan
Test links
Deploy preview: https://deploy-preview-8227--docusaurus-2.netlify.app/
Related issues/PRs