Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(theme-translations): complete pl translations #8525

Merged
merged 10 commits into from Jan 18, 2023
Merged

chore(theme-translations): complete pl translations #8525

merged 10 commits into from Jan 18, 2023

Conversation

mariuszkrzaczkowski
Copy link
Contributor

@mariuszkrzaczkowski mariuszkrzaczkowski commented Jan 9, 2023 •
edited

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 9, 2023
@netlify
Copy link

netlify bot commented Jan 9, 2023 •
edited

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 22e159d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63c66f264f43f40008166e2d
😎 Deploy Preview https://deploy-preview-8525--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 70 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 73 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena mentioned this pull request Jan 10, 2023
Closed
3 tasks
@Josh-Cena Josh-Cena changed the title theme-common.json Polish translations chore(theme-translations): complete pl translations Jan 10, 2023
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jan 10, 2023
@Josh-Cena
Copy link
Collaborator

cc @Simek could you help with reviewing this? Thank you!

@mariuszkrzaczkowski @Simek
Update packages/docusaurus-theme-translations/locales/pl/theme-common…
d74a804 
….json

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
@mariuszkrzaczkowski @Simek
Update packages/docusaurus-theme-translations/locales/pl/theme-common…
0b25e32 
….json

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
@mariuszkrzaczkowski @Simek
Update packages/docusaurus-theme-translations/locales/pl/theme-common…
60c65be 
….json

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
@mariuszkrzaczkowski @Simek
Update packages/docusaurus-theme-translations/locales/pl/theme-search…
7dcb642 
…-algolia.json

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
@mariuszkrzaczkowski @Simek
Update packages/docusaurus-theme-translations/locales/pl/theme-search…
bf435f4 
…-algolia.json

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
@mariuszkrzaczkowski @Simek
Update packages/docusaurus-theme-translations/locales/pl/theme-search…
16ff944 
…-algolia.json

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
@mariuszkrzaczkowski @Simek
Update packages/docusaurus-theme-translations/locales/pl/theme-search…
a8a6279 
…-algolia.json

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
@mariuszkrzaczkowski
Copy link
Contributor Author

@Simek 👌

@mariuszkrzaczkowski @Simek
Update packages/docusaurus-theme-translations/locales/pl/theme-common…
22e159d 
….json

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
@Simek
Copy link
Contributor

Simek commented Jan 17, 2023

Thank you for the quick updates @mariuszkrzaczkowski! 🙏

@Josh-Cena The PR should be ready to ship, at least from the content side.

Josh-Cena
Josh-Cena approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your review @Simek and @mariuszkrzaczkowski for your contribution!

@Josh-Cena Josh-Cena merged commit 8714a95 into facebook:main Jan 18, 2023
@Josh-Cena Josh-Cena added the to backport This PR is planned to be backported to a stable version of Docusaurus label Jan 18, 2023
slorber pushed a commit that referenced this pull request Jan 26, 2023
@mariuszkrzaczkowski @slorber
chore(theme-translations): complete pl translations #8525
61f7d56
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 27, 2023
@slorber slorber mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek Simek left review comments

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mariuszkrzaczkowski @Josh-Cena @Simek @slorber @facebook-github-bot