Skip to content
Permalink
Branch: master
Commits on Mar 21, 2019
  1. Upgrades react-scripts to ^1.1.5 (#2042)

    claudiopro authored and facebook-github-bot committed Mar 21, 2019
    Summary:
    **Summary**
    
    Upgrades react-scripts to ^1.1.5 to remove an indirect dependency on the [vulnerable package macaddress@0.2.8](https://snyk.io/vuln/SNYK-JS-MACADDRESS-12141).
    
    **Test Plan**
    
    Smoke test the Draft.js playground
    
    ```
    cd examples/draft-0-10-0/playground
    yarn install
    yarn run start
    ```
    Pull Request resolved: #2042
    
    Reviewed By: anarelion
    
    Differential Revision: D14560176
    
    Pulled By: anarelion
    
    fbshipit-source-id: b109049e545361db9ed0a35b7242fac5fd85cdc3
Commits on Mar 20, 2019
  1. Upgrades docusaurus (#2039)

    claudiopro authored and facebook-github-bot committed Mar 20, 2019
    Summary:
    **Summary**
    
    Runs `yarn upgrade docusaurus` to ensure we're on the latest set of dependencies
    
    **Test Plan**
    
    Run the docusaurus build and test the website on http://localhost:3000/
    
    ```
    cd website
    yarn run build
    yarn run start
    ```
    Pull Request resolved: #2039
    
    Reviewed By: mrkev
    
    Differential Revision: D14539917
    
    Pulled By: mrkev
    
    fbshipit-source-id: 16f79868bbae7e78076df26997021b13b097d66d
Commits on Mar 8, 2019
  1. Removes unused gulp-browserify-thin (#2032)

    claudiopro authored and facebook-github-bot committed Mar 8, 2019
    Summary:
    **Summary**
    
    Removes unused dev dependency on `gulp-browserify-thin`. Addresses a security vulnerability that affects `minimatch@2.0.10` indirectly required through this module.
    
    ```
    → yarn why minimatch
    Using globally installed version of Yarn
    yarn why v1.12.1
    [1/4] �  Why do we have the module "minimatch"...?
    [2/4] 🚚  Initialising dependency graph...
    [3/4] 🔍  Finding dependency...
    [4/4] 🚡  Calculating file sizes...
    => Found "minimatch@3.0.4"
    info Has been hoisted to "minimatch"
    info Reasons this module exists
       - Hoisted from "eslint#minimatch"
       - Hoisted from "glob#minimatch"
       - Hoisted from "gulp-if#gulp-match#minimatch"
       - Hoisted from "jest#jest-cli#istanbul-api#minimatch"
       - Hoisted from "gulp-concat-css#rework-import#globby#glob#minimatch"
       - Hoisted from "envify#jstransform#commoner#glob#minimatch"
       - Hoisted from "jest#jest-cli#istanbul-api#fileset#minimatch"
       - Hoisted from "jest#jest-cli#jest-runtime#babel-plugin-istanbul#test-exclude#minimatch"
       - Hoisted from "gulp#glob-watcher#chokidar#fsevents#node-pre-gyp#npm-packlist#ignore-walk#minimatch"
    info Disk size without dependencies: "44KB"
    info Disk size with unique dependencies: "64KB"
    info Disk size with transitive dependencies: "120KB"
    info Number of shared dependencies: 1
    => Found "browserify#minimatch@2.0.10"
    info Reasons this module exists
       - "gulp-browserify-thin#browserify#glob" depends on it
       - Hoisted from "gulp-browserify-thin#browserify#glob#minimatch"
    info Disk size without dependencies: "76KB"
    info Disk size with unique dependencies: "96KB"
    info Disk size with transitive dependencies: "152KB"
    info Number of shared dependencies: 1
      Done in 0.96s.
    ```
    
    **Test Plan**
    
    Check if `gulp-browserify-thin` is required anywhere, it is not.
    Pull Request resolved: #2032
    
    Reviewed By: mrkev
    
    Differential Revision: D14388097
    
    Pulled By: mrkev
    
    fbshipit-source-id: 6b9b46ec8129d7899805021fbd6d6d1f8b9e443b
Commits on Mar 7, 2019
  1. Upgrades @babel/core, babel-preset-fbjs, and gulp-util (#2028)

    claudiopro authored and facebook-github-bot committed Mar 7, 2019
    Summary:
    **Summary**
    
    Addresses broken flow types extracted during the gulp build. Solves #2027
    
    Upgrades the following dependencies:
    
    - babel-core@^6.8.0 -> babel/core@^7.3.4
    - babel-preset-fbjs@^2.1.0 -> ^3.2.0
    - fbjs-scripts@^0.8.0 -> ^1.1.0
    - gulp-babel@^6.1.2 -> ^8.0.0
    - jest@^23.5.0 -> ^24.1.0
    
    **Test Plan**
    
    yarn
    yarn test
    yarn flow
    
    Manual inspection of generated flow types under `lib/`
    Pull Request resolved: #2028
    
    Reviewed By: mitermayer
    
    Differential Revision: D14366317
    
    Pulled By: mitermayer
    
    fbshipit-source-id: 734c15717e94c3bc7f1a552496b67ce6a509da06
Commits on Feb 26, 2019
  1. Restores flow error suppression for fbjs@1.0.0 (#2014)

    claudiopro authored and facebook-github-bot committed Feb 26, 2019
    Summary:
    **Summary**
    
    Restores a flow error suppression annotation removed with D14074027
    
    **Test Plan**
    
    `yarn run flow`
    No errors
    Pull Request resolved: #2014
    
    Reviewed By: dsainati1
    
    Differential Revision: D14229161
    
    Pulled By: dsainati1
    
    fbshipit-source-id: b169d832d0b50e3366a94d53ae7e60ca89035ae7
Commits on Feb 14, 2019
  1. Handles <br> tags in refactored HTML converter

    claudiopro authored and facebook-github-bot committed Feb 14, 2019
    Summary: This diff aligns the refactored HTML converter with the legacy one to correctly handle <br> tags
    
    Reviewed By: mitermayer
    
    Differential Revision: D14027112
    
    fbshipit-source-id: 68c2ae2272bac4e2d90a72b71cfb43f7b20faa3a
Commits on Feb 9, 2019
  1. Normalize case in convertFromHTMLToContentBlocks variable names

    claudiopro authored and facebook-github-bot committed Feb 8, 2019
    Summary: Normalize case in `convertFromHTMLToContentBlocks` variable names. It is often found as `convertFromHTMLtoContentBlocks` (lowercase 'to') and can give us unpleasant surprises in case of codemods
    
    Reviewed By: mitermayer
    
    Differential Revision: D14004772
    
    fbshipit-source-id: e7dc11a6eeedbf2fa3ca607f613f99fa6583942a
Commits on Feb 8, 2019
  1. Cleans up and refreshes generated website resources (#1998)

    claudiopro authored and facebook-github-bot committed Feb 8, 2019
    Summary:
    **Summary**
    
    Cleans up unused website resources from before the migration to Docusaurus, and makes sure static website resources are generated and refreshed at every build.
    
    **Test Plan**
    
    ```
    yarn
    cd website
    yarn build
    yarn start
    ```
    
    Website loads and pages contain the expected content.
    Pull Request resolved: #1998
    
    Reviewed By: niveditc
    
    Differential Revision: D14004275
    
    Pulled By: niveditc
    
    fbshipit-source-id: 2d0afaf448ae5d1c6f9f6915e530c50c983135d1
Commits on Feb 7, 2019
  1. Upgrades Draft to React 16.8 ⚛️ (#1996)

    claudiopro authored and facebook-github-bot committed Feb 7, 2019
    Summary:
    **Summary**
    
    Upgrades [react](https://npm.im/react) and [react-dom](https://npm.im/react-dom) dependencies to the freshly released 16.8 version supporting Hooks.
    
    **Test Plan**
    
    `yarn`
    manual smoke test of editor in examples
    Pull Request resolved: #1996
    
    Differential Revision: D13982016
    
    fbshipit-source-id: b2f87a1d85336f60d7a03318e5e0155bb3c44fc8
Commits on Feb 4, 2019
  1. Adds email notifications for TravisCI builds (#1990)

    claudiopro authored and facebook-github-bot committed Feb 4, 2019
    Summary:
    **Summary**
    
    Adds claudiopro 's email for TravisCI build notifications. Feel free to do the same if you want to stay in the loop.
    
    **Test Plan**
    
    Wait for the next build to receive an email from TravisCI �‍♂️
    Pull Request resolved: #1990
    
    Reviewed By: elboman
    
    Differential Revision: D13935604
    
    Pulled By: elboman
    
    fbshipit-source-id: 0a3020e65890793b82c87626f6da284ec310805c
Commits on Feb 1, 2019
  1. Upgrades flow-bin to 0.91.0 and mutes fbjs joinClasses error � (#1989)

    claudiopro authored and facebook-github-bot committed Feb 1, 2019
    Summary:
    **Summary**
    
    Fixes a CI build error (#1988) by adding a `$FlowExpectedError` annotation, and upgrading [flow-bin](https://www.npmjs.com/package/flow-bin) to 0.91.0
    
    **Test Plan**
    
    ```
    yarn run flow
    flow src
    ```
    
    ```
    → flow src
    The flow server's version didn't match the client's, so it exited.
    Going to launch a new one.
    
    Launching Flow server for /Users/procidac/Development/gh/claudiopro/draft-js/src
    Spawned flow server (pid=87525)
    Logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.log
    Monitor logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.monitor_log
    No errors!
    ```
    Pull Request resolved: #1989
    
    Reviewed By: pakoito
    
    Differential Revision: D13917267
    
    Pulled By: pakoito
    
    fbshipit-source-id: ce66ee4c67c4e7cc46c51ca91a4ade3d980fdf2e
Commits on Jan 22, 2019
  1. Fixes lint warnings in convertFromHTMLToContentBlocks2 tests

    claudiopro authored and facebook-github-bot committed Jan 22, 2019
    Summary: Fixes lint warnings in convertFromHTMLToContentBlocks2 tests and initializes with defaults from the `clear` method.
    
    Reviewed By: j-nolan
    
    Differential Revision: D13711386
    
    fbshipit-source-id: e5562b69c4388b75ea5a0b5abfb4508ad9096a87
Commits on Jan 4, 2019
  1. Relicense under MIT and remove patents grant (#1967)

    claudiopro authored and facebook-github-bot committed Jan 4, 2019
    Summary:
    **Summary**
    
    After internal discussion and approval by the legal team, we decided to align Draft.js with other Facebook open source projects [recently re-licensed under MIT](https://code.fb.com/web/relicensing-react-jest-flow-and-immutable-js/).
    
    This PR removes the patents grant and re-licenses all Draft.js source files under the MIT license.
    
    **Test Plan**
    
    `yarn lint`
    Manual code inspection
    Pull Request resolved: #1967
    
    Differential Revision: D13572529
    
    fbshipit-source-id: f59982148515fdc7a2f697c92e1939e211b6125c
Commits on Jan 3, 2019
  1. Normalize copyright headers to BSD + patents grant and drop the year (#…

    claudiopro authored and facebook-github-bot committed Jan 3, 2019
    …1964)
    
    Summary:
    **Summary**
    
    This PR follows up work started by niveditc on #1860 and suspended because of limitations with tooling. Let's give it another try.
    
    - Remove all copyright years
    - Correct copyright headers under `website/` referencing the MIT license
    - Inline `All rights reserved.` on the same line of the copyright
    - Fixes copyright headers of examples incorrectly using headers for source files
    
    The PR also normalizes copyright headers to BSD with patents grant, as some files were later added with the newest MIT license applied to React and other OSS projects. We should discuss the switch to MIT for Draft.js as well.
    
    **Test Plan**
    
    Manual inspection of files + `yarn lint`
    Pull Request resolved: #1964
    
    Differential Revision: D13562427
    
    fbshipit-source-id: 6a15d29ff56a6340ee2a0f13f278b207f1761d28
Commits on Dec 26, 2018
  1. Fixes flow error (#1962)

    claudiopro authored and facebook-github-bot committed Dec 26, 2018
    Summary:
    **Summary**
    
    Fixes a flow error in master (#1961) by replacing an inline `$FlowFixMe` with the appropriate type `string`
    
    **Test Plan**
    
    ```
    → yarn flow
    Using globally installed version of Yarn
    yarn run v1.12.1
    $ flow src
    No errors!
      Done in 0.28s.
    ```
    Pull Request resolved: #1962
    
    Differential Revision: D13548249
    
    fbshipit-source-id: 6975261897187560536a08fafc24c3400d7bf645
Commits on Oct 4, 2018
  1. Clarifies editor example, changes height to min-height (#1889)

    claudiopro authored and facebook-github-bot committed Oct 4, 2018
    Summary:
    **Summary**
    
    Clarifies editor example, explaining how to use CSS selectors from the Draft.css stylesheet, changes `height` to `min-height` in example.
    
    **Test Plan**
    
    Tests on CodeSandbox: https://codesandbox.io/s/9y5162ryj4
    Pull Request resolved: #1889
    
    Differential Revision: D10207706
    
    fbshipit-source-id: cf3a6eb659f486ec9a0d6e64018478b113c20922
  2. Improves editor overview example with min height and border (#1887)

    claudiopro authored and facebook-github-bot committed Oct 4, 2018
    Summary:
    **Summary**
    
    Improves editor overview example providing a code sample that sets the editor's min height and border, as well as focuses the editor when clicking the editor area.
    
    **Test Plan**
    
    Copy and paste example into CodeSandbox
    https://codesandbox.io/s/9y5162ryj4
    
    Fixes #1880
    Pull Request resolved: #1887
    
    Differential Revision: D10200611
    
    fbshipit-source-id: 5c261cf78d8d36e3255528b68d30d7b46e2908bf
  3. Adds iframed editor example (#1879)

    claudiopro authored and facebook-github-bot committed Oct 4, 2018
    Summary:
    **Summary**
    
    Adds an iframed editor example to Draft.js based on haikyuu's CodeSandbox demo https://codesandbox.io/s/y0q1q281kz
    
    **Test Plan**
    
    ```
    git clone claudiopro/draft-js .
    cd draft-js
    git checkout iframe-example
    python3 -m http.server 8000
    open http://localhost:8000/examples/draft-0-10-0/iframe/iframe.html
    ```
    <img width="1072" alt="screen shot 2018-09-24 at 4 23 24 pm" src="https://user-images.githubusercontent.com/860099/45957816-396c1c00-c016-11e8-9808-c4453ff6c4ff.png">
    Pull Request resolved: #1879
    
    Differential Revision: D10194094
    
    fbshipit-source-id: 0beabd7b890fbc31acdc84a780d6e91ca1de31a4
Commits on Sep 15, 2018
  1. Updates favicons and launcher icons with Draftjs logo (#1872)

    claudiopro authored and facebook-github-bot committed Sep 15, 2018
    Summary:
    **Summary**
    
    Updates icons and launcher icons to use the Draftjs logo on a maroon backdrop instead of the "D" letter.
    
    **Test Plan**
    
    * `yarn build && cd website && yarn start`
    * Verify the favicon is the new icon with the Draftjs logo
    
    <img width="170" alt="screen shot 2018-09-15 at 2 06 40 pm" src="https://user-images.githubusercontent.com/860099/45586618-1e9cf780-b8f2-11e8-8b7a-ebc20af5e5c4.png">
    
    _**Note**: apparently, Docusaurus doesn't seem to use the apple and android launcher icons on this config. I'll try and look into that on a separate PR (will add support into Docusaurus itself if needed)_
    Pull Request resolved: #1872
    
    Differential Revision: D9846099
    
    fbshipit-source-id: 347ae57270eebaeedadd324af9ca78a74421713c
Commits on Sep 5, 2018
  1. Fixes warning for missing keys in example color controls (#1853)

    claudiopro authored and facebook-github-bot committed Sep 5, 2018
    Summary:
    **Summary**
    
    Fixes a warning in the color examples for missing keys for elements in an array for the style controls.
    
    ```
    react.development.js:336 Warning: Each child in an array or iterator should have a unique "key" prop.
    
    Check the render method of `ColorControls`. See https://fb.me/react-warning-keys for more information.
        in StyleButton (created by ColorControls)
        in ColorControls (created by ColorfulEditorExample)
        in div (created by ColorfulEditorExample)
        in ColorfulEditorExample
    ```
    
    **Test Plan**
    
    Manual tests on Chrome, warnings are gone
    
    **Note:** This PR also fixes the [Travis CI build failure](https://travis-ci.org/facebook/draft-js/jobs/424170309) introduced with e6c693c
    Pull Request resolved: #1853
    
    Differential Revision: D9654616
    
    fbshipit-source-id: 1e4e9a4ef2eb896306404acc31623076e107b91c
You can’t perform that action at this time.