Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fix #1326 Safari can't focus with draggable parent #1356
Conversation
facebook-github-bot
added
the
CLA Signed
label
Sep 1, 2017
mattkrick
referenced this pull request
in ParabolInc/action
Sep 1, 2017
Closed
TypeError: Cannot read property 'getIn' of undefined #1317
jordanh
commented
Sep 1, 2017
|
|
jordanh
referenced this pull request
in ParabolInc/action
Sep 2, 2017
Merged
update draft to my github branch fix #1317 #1323
mattkrick
added some commits
Sep 1, 2017
flarnie
self-requested a review
Sep 12, 2017
|
Thanks for submitting this! The bug is easy to reproduce, and I'm still testing to verify that your change fixes it. |
flarnie
approved these changes
Sep 22, 2017
Awesome detective work!
Adding this to the queue for merging~
facebook-github-bot
commented
Sep 25, 2017
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Sep 25, 2017
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Sep 25, 2017
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Sep 25, 2017
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
flarnie
added this to the v0.10.4 milestone
Sep 28, 2017
facebook-github-bot
commented
Sep 29, 2017
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Sep 29, 2017
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mattkrick commentedSep 1, 2017
Summary
DraftEditors that lived inside draggable parents were useless in Safari. Now they work.
Solution found here: react-dnd/react-dnd#178 (comment)
Test Plan
Use the fiddle in #1326 with the updated version.
For a quick n dirty, just add this to the stylesheet:
div[contenteditable="true"] { user-select: text;}