New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1326 Safari can't focus with draggable parent #1356

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@mattkrick
Contributor

mattkrick commented Sep 1, 2017

Summary

DraftEditors that lived inside draggable parents were useless in Safari. Now they work.
Solution found here: react-dnd/react-dnd#178 (comment)

Test Plan

Use the fiddle in #1326 with the updated version.
For a quick n dirty, just add this to the stylesheet:
div[contenteditable="true"] { user-select: text;}

@jordanh

This comment has been minimized.

jordanh commented Sep 1, 2017

👏 👏 👏

mattkrick added some commits Sep 1, 2017

@flarnie flarnie self-requested a review Sep 12, 2017

@flarnie

This comment has been minimized.

Contributor

flarnie commented Sep 22, 2017

Thanks for submitting this!

The bug is easy to reproduce, and I'm still testing to verify that your change fixes it.

@flarnie

Awesome detective work!
happyjello
Adding this to the queue for merging~

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Sep 25, 2017

@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

3 similar comments
@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Sep 25, 2017

@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Sep 25, 2017

@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Sep 25, 2017

@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@flarnie flarnie added this to the v0.10.4 milestone Sep 28, 2017

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Sep 29, 2017

@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Sep 29, 2017

@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment