Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node 6 from engines list in package.json #1652

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@thibaudcolas
Copy link
Contributor

thibaudcolas commented Feb 16, 2018

Summary

Fixes #1650.

Travis is using Node 8 since 247a632, and Prettier is already configured in a way that's not Node-6 compatible:

trailingComma: 'all',

Node 8 is the LTS release line since late october 2017 so I think it's fair to remove support for Node 6.

NB: I see devEngines also states support for npm 2 and 3. Node 8 ships with npm 5 by default, so I imagine those 2 versions could be removed as well. Edit: Ah actually I see draft-js is at least partially using yarn since #1568 / #1570.

Test plan

No tests. This is only removing support, it doesn't affect supported versions.

Remove Node 6 from engines list in package.json
Fixes #1650. Travis is using Node 8 since 247a632, and Prettier is already configured in a way that's not Node-6 compatible (`trailingComma: 'all',`, https://github.com/facebook/draft-js/blob/a6317e60b06519d3c00a2c0621701f3da0837a88/prettier.config.js#L3)
@mitermayer

This comment has been minimized.

Copy link
Member

mitermayer commented Feb 16, 2018

Thanks for the PR, this looks reasonable to me, any thoughts @flarnie ?

@flarnie
Copy link
Contributor

flarnie left a comment

lgtm_goat

@facebook-github-bot
Copy link

facebook-github-bot left a comment

@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

facebook-github-bot left a comment

@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@thibaudcolas thibaudcolas deleted the thibaudcolas:patch-1 branch Feb 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.