Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copyright headers #1860

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@niveditc
Copy link
Contributor

niveditc commented Sep 9, 2018

Summary
The open source checkup tool told us that we were missing copyright headers on some files. I also found out that the recommendation is now to remove the date from these headers, so updated existing files via codemod.

> codemod -m --extensions js -d src 'Copyright \(c\) 2013\-present, Facebook, Inc\.. \* All rights reserved\.' 'Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.'

Test Plan
None

@cdelahousse

This comment has been minimized.

Copy link

cdelahousse commented Sep 10, 2018

Nice. Looks good to me.

@facebook-github-bot
Copy link

facebook-github-bot left a comment

niveditc is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@marcelometal

This comment has been minimized.

Copy link
Contributor

marcelometal commented Oct 16, 2018

Hi @niveditc, Why remove year from copyright notice?

facebook-github-bot added a commit that referenced this pull request Jan 3, 2019

Normalize copyright headers to BSD + patents grant and drop the year (#…
…1964)

Summary:
**Summary**

This PR follows up work started by niveditc on #1860 and suspended because of limitations with tooling. Let's give it another try.

- Remove all copyright years
- Correct copyright headers under `website/` referencing the MIT license
- Inline `All rights reserved.` on the same line of the copyright
- Fixes copyright headers of examples incorrectly using headers for source files

The PR also normalizes copyright headers to BSD with patents grant, as some files were later added with the newest MIT license applied to React and other OSS projects. We should discuss the switch to MIT for Draft.js as well.

**Test Plan**

Manual inspection of files + `yarn lint`
Pull Request resolved: #1964

Differential Revision: D13562427

fbshipit-source-id: 6a15d29ff56a6340ee2a0f13f278b207f1761d28
@claudiopro

This comment has been minimized.

Copy link
Member

claudiopro commented Jan 3, 2019

Superseded by #1964.

@claudiopro claudiopro closed this Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.