Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize copyright headers to BSD + patents grant and drop the year #1964

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
3 participants
@claudiopro
Copy link
Member

commented Dec 29, 2018

Summary

This PR follows up work started by @niveditc on #1860 and suspended because of limitations with tooling. Let's give it another try.

  • Remove all copyright years
  • Correct copyright headers under website/ referencing the MIT license
  • Inline All rights reserved. on the same line of the copyright
  • Fixes copyright headers of examples incorrectly using headers for source files

The PR also normalizes copyright headers to BSD with patents grant, as some files were later added with the newest MIT license applied to React and other OSS projects. We should discuss the switch to MIT for Draft.js as well.

Test Plan

Manual inspection of files + yarn lint

@niveditc
Copy link
Contributor

left a comment

Looks good! Thanks for taking a stab at this again 👍

The issue last time was with out internal linter not recognizing copyright headers without year (see D9754843) - not sure if that got fixed, let's check it out on import :)

@claudiopro claudiopro force-pushed the claudiopro:fix-copyright-headers branch from 06380f4 to 48f2457 Dec 30, 2018

@claudiopro

This comment has been minimized.

Copy link
Member Author

commented Dec 30, 2018

Sounds good, thanks @niveditc ! 😄

@facebook-github-bot
Copy link

left a comment

@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

left a comment

@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

left a comment

@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

left a comment

@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@claudiopro claudiopro deleted the claudiopro:fix-copyright-headers branch Jan 3, 2019

@claudiopro claudiopro referenced this pull request Jan 3, 2019

Closed

Fix copyright headers #1860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.