Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Add deprecated examples #824

Merged

Conversation

tobiasandersen
Copy link
Contributor

Summary

This is mainly a PR for #816. It moves the current examples into a new 'draft-0-10-0' directory and re-adds the deprecated examples into a new 'draft-0-9-1' directory. Since the examples are now located one level deeper than before, the paths to 'node_modules' and 'dist' have been updated.

It also fixes #815 by not using the minified version of React. So all examples should be working properly now.

@flarnie
Copy link
Contributor

flarnie commented Nov 30, 2016

Thanks for doing this! It looks like the website actually uses the Rich Text Editor example css, so we need to update the path for that. That's why the CI build failed.
https://github.com/facebook/draft-js/blob/69890ed57b5f4256cc93ae8e9ea178296851a23e/website/server/convert.js#L113

Similarly, the documentation links to the examples, so those paths should be updated.

Lastly - in the /tex examples the path in the local package.json needed to be updated.

I'll see if I can edit this PR and add those tweaks, and then this should be good to land. If that doesn't work then I'll ask you to revise it.

It's great to see this happening - glad to have your help Tobias.

 - updates the .gitignore to ignore node_modules in both the new
   locations of the 'tex' example
 - updates a path in the script used for the draft js docs website,
   which pulls styles from the 'rich' example for some reason
 - updates the path for 'npm install' in the 'tex' examples
 - updates all links in the markdown used to generate the draft js docs.
@tobiasandersen
Copy link
Contributor Author

Oh I didn't think about that, thanks! Just let me know if there's anything else needed.

@flarnie flarnie merged commit b17eb8b into facebookarchive:master Dec 2, 2016
flarnie added a commit that referenced this pull request Mar 18, 2017
This is the second step in updating our examples so that we no longer
support multiple versions of Draft.

Since the latest release will only support one API for entity
management, the examples can reflect that updated API.

So basically undoing the work that @tobiasanderson kindly did in
#824
ouchxp pushed a commit to ouchxp/draft-js that referenced this pull request Apr 7, 2017
* Move current examples into draft-0-10-0 dir

* Add examples for version 0.9.1 into draft-0-9-1 dir

* Use unminified version of react in all examples

* Update file paths for examples

* Update paths in gitignore, 'tex' package.json, and draftjs docs

 - updates the .gitignore to ignore node_modules in both the new
   locations of the 'tex' example
 - updates a path in the script used for the draft js docs website,
   which pulls styles from the 'rich' example for some reason
 - updates the path for 'npm install' in the 'tex' examples
 - updates all links in the markdown used to generate the draft js docs.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'color' and 'rich' examples failing on master
3 participants