This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Add deprecated examples #824
Merged
flarnie
merged 5 commits into
facebookarchive:master
from
tobiasandersen:add-deprecated-examples
Dec 2, 2016
Merged
Add deprecated examples #824
flarnie
merged 5 commits into
facebookarchive:master
from
tobiasandersen:add-deprecated-examples
Dec 2, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2016
Thanks for doing this! It looks like the website actually uses the Rich Text Editor example css, so we need to update the path for that. That's why the CI build failed. Similarly, the documentation links to the examples, so those paths should be updated. Lastly - in the I'll see if I can edit this PR and add those tweaks, and then this should be good to land. If that doesn't work then I'll ask you to revise it. It's great to see this happening - glad to have your help Tobias. |
- updates the .gitignore to ignore node_modules in both the new locations of the 'tex' example - updates a path in the script used for the draft js docs website, which pulls styles from the 'rich' example for some reason - updates the path for 'npm install' in the 'tex' examples - updates all links in the markdown used to generate the draft js docs.
Oh I didn't think about that, thanks! Just let me know if there's anything else needed. |
flarnie
added a commit
that referenced
this pull request
Mar 18, 2017
This is the second step in updating our examples so that we no longer support multiple versions of Draft. Since the latest release will only support one API for entity management, the examples can reflect that updated API. So basically undoing the work that @tobiasanderson kindly did in #824
ouchxp
pushed a commit
to ouchxp/draft-js
that referenced
this pull request
Apr 7, 2017
* Move current examples into draft-0-10-0 dir * Add examples for version 0.9.1 into draft-0-9-1 dir * Use unminified version of react in all examples * Update file paths for examples * Update paths in gitignore, 'tex' package.json, and draftjs docs - updates the .gitignore to ignore node_modules in both the new locations of the 'tex' example - updates a path in the script used for the draft js docs website, which pulls styles from the 'rich' example for some reason - updates the path for 'npm install' in the 'tex' examples - updates all links in the markdown used to generate the draft js docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is mainly a PR for #816. It moves the current examples into a new 'draft-0-10-0' directory and re-adds the deprecated examples into a new 'draft-0-9-1' directory. Since the examples are now located one level deeper than before, the paths to 'node_modules' and 'dist' have been updated.
It also fixes #815 by not using the minified version of React. So all examples should be working properly now.