From 39a6a4c6ec53cc532707083d5f370004d021c183 Mon Sep 17 00:00:00 2001
From: Giovanni Cappellotto <gcappellotto@fb.com>
Date: Thu, 15 Nov 2018 07:11:29 -0800
Subject: [PATCH] Add missing pattern match

Summary:
`fromName` was missing a pattern to match the new `"credit-card-number"` dimension string representation.

Adding also `CreditCardNumber.Tests.tests` to the `Dimensions Tests` test group.

Reviewed By: chinmay87

Differential Revision: D13072125

fbshipit-source-id: 792727ef038d26ae12ceea909fa726692d56db6d
---
 Duckling/Dimensions/Types.hs       | 1 +
 tests/Duckling/Dimensions/Tests.hs | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Duckling/Dimensions/Types.hs b/Duckling/Dimensions/Types.hs
index f2cff19c5..37e1b5463 100644
--- a/Duckling/Dimensions/Types.hs
+++ b/Duckling/Dimensions/Types.hs
@@ -50,6 +50,7 @@ fromName name = HashMap.lookup name m
   where
     m = HashMap.fromList
       [ ("amount-of-money", This AmountOfMoney)
+      , ("credit-card-number", This CreditCardNumber)
       , ("distance", This Distance)
       , ("duration", This Duration)
       , ("email", This Email)
diff --git a/tests/Duckling/Dimensions/Tests.hs b/tests/Duckling/Dimensions/Tests.hs
index 92acf7afb..fd45976ab 100644
--- a/tests/Duckling/Dimensions/Tests.hs
+++ b/tests/Duckling/Dimensions/Tests.hs
@@ -15,6 +15,7 @@ import Prelude
 import Test.Tasty
 
 import qualified Duckling.AmountOfMoney.Tests as AmountOfMoney
+import qualified Duckling.CreditCardNumber.Tests as CreditCardNumber
 import qualified Duckling.Distance.Tests as Distance
 import qualified Duckling.Duration.Tests as Duration
 import qualified Duckling.Email.Tests as Email
@@ -30,6 +31,7 @@ import qualified Duckling.Url.Tests as Url
 tests :: TestTree
 tests = testGroup "Dimensions Tests"
   [ AmountOfMoney.tests
+  , CreditCardNumber.tests
   , Distance.tests
   , Duration.tests
   , Email.tests