Skip to content
This repository

Mar 24, 2014

  1. clang13

    Facebook Android SDK 3.8

    Summary: Facebook Android SDK 3.8 (see https://developers.facebook.com/docs/android/change-log-3.x/)
    
    Test Plan: Built ZIP
    
    Reviewers: mingfli
    
    Reviewed By: mingfli
    
    CC: subodh
    
    Differential Revision: https://phabricator.fb.com/D1237186
    authored

Feb 21, 2014

  1. Ming Li

    Facebook Android SDK 3.7

    Summary: Facebook Android SDK 3.7 (see https://developers.facebook.com/docs/android/change-log-3.x/)
    
    Test Plan: Built ZIP
    
    Reviewers: clang
    
    Reviewed By: clang
    
    CC: glen, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D1183743
    authored

Dec 10, 2013

  1. Ming Li

    Facebook Android SDK 3.6.0

    Summary:
    Modified
    + AppEventsLogger is now out of Beta, setLimitEventUsage is deprecated and moved to Settings as setLimitEventAndDataUsage
    
    Added
    + Added setSelection methods on FriendPickerFragment to allow pre-selection of friends.
    + Added example use of setSelection API in Friend Picker Sample
    + Added support for Gradle.
    
    Fixed
    + Fixed bug in WebDialogs where the dialog would not display properly for large displays with soft keyboards
    + Fixed bug where the callback for NewPermissionsRequest was not called
    + Fixed bug in AuthorizationClient where it can hang on orientation changes
    
    Test Plan: Tested on emulator
    
    Reviewers: clang
    
    Reviewed By: clang
    
    CC: platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D1089971
    authored

Oct 01, 2013

  1. clang13

    Facebook Android SDK 3.5.2 (see https://developers.facebook.com/docs/…

    …android/change-log-3.x/)
    
    Summary: Facebook Android SDK 3.5.2 (see https://developers.facebook.com/docs/android/change-log-3.x/)
    
    Test Plan: - Built ZIP
    
    Reviewers: mingfli
    
    Reviewed By: mingfli
    
    CC:
    
    Differential Revision:
    authored

Sep 26, 2013

  1. clang13

    Facebook Android SDK 3.5.1 (see https://developers.facebook.com/docs/…

    …android/change-log-3.x/)
    
    Summary: Facebook Android SDK 3.5.1 (see https://developers.facebook.com/docs/android/change-log-3.x/)
    
    Test Plan: - Built ZIP
    
    Reviewers: mingfli
    
    Reviewed By: mingfli
    
    CC: subodh, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D986742
    authored

Aug 20, 2013

  1. clang13

    Facebook Android SDK 3.5 (see https://developers.facebook.com/android…

    …/change-log-3.x/)
    
    Summary: Facebook Android SDK 3.5
    
    Test Plan: - Release testing
    
    Reviewers: mingfli
    
    Reviewed By: mingfli
    
    CC: platform-diffs@lists, subodh, dreiss
    
    Differential Revision: https://phabricator.fb.com/D935263
    authored

Jul 03, 2013

  1. Ming Li

    Facebook Android SDK 3.0.2 (see https://developers.facebook.com/andro…

    …id/change-log-3.x)
    
    Summary:
        - Updating project structure to work with ADT v22.
    
    Test Plan: Release testing
    
    Reviewers: clang
    
    Reviewed By: clang
    
    CC: platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D874918
    authored

Mar 20, 2013

  1. Michael Marucheck

    Facebook SDK 3.0.1 for Android (see https://developers.facebook.com/a…

    …ndroid/change-log-3.x)
    
    Summary:
    - A number of bug fixes from the Facebook SDK 3.0 Release
    - Additional overloads for publishInstall
    - Addition of InsightsLogger and ability to log conversion pixels and purchase events
    
    Test Plan: Release testing
    
    Reviewers: gregschechte
    
    Reviewed By: gregschechte
    authored Greg Schechter committed

Dec 13, 2012

  1. Michael Marucheck

    Updating version string to 3.0

    Summary: See title
    
    Test Plan: - test pass
    
    Reviewers: clang, mingfli
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D657738
    authored
  2. Ming Li

    Replacing square image with a better color.

    Summary: Color match square image with portrait.
    
    Test Plan: tested on profile picture sample.
    
    Reviewers: mmarucheck, clang
    
    Reviewed By: mmarucheck
    
    CC: ekoneil
    
    Differential Revision: https://phabricator.fb.com/D657590
    
    Task ID: 1783083
    authored
  3. clang13

    [android-sdk] Don't give focus to search box immediately when PlacePi…

    …ckerFragment shown; naming issues in SessionLoginSample
    
    Summary:
    Previously, the search box (if displayed) in PlacePickerFragment would get focus as soon as the picker was shown, bringing
    up the keyboard on many devices and making it difficult to scroll the list of results. Changing to keep it from getting
    focus until the user touches it so the entire area is used for displaying results.
    
    SessionLoginSample had a poorly-named MainActivity and referred to the since-renamed LoginFragment in its UI.
    
    Test Plan:
    - Ran PlacePickerSample, did not see the keyboard until I pressed in the search box
    - Ran SessionLoginSample, verified rewording in UI
    
    Revert Plan:
    
    Reviewers: mmarucheck, mingfli, karthiks
    
    Reviewed By: mmarucheck
    
    Differential Revision: https://phabricator.fb.com/D656709
    
    Task ID: 1956968, 1957867
    authored
  4. clang13

    [android-sdk] Rather than throw if an auth request comes in when one …

    …is pending, report the error via the callback and leave state unchanged.
    
    Summary:
    Previously, we would throw if an open()-ish call came into a Session while another request was pending. App UI may allow
    this to happen (for instance, a user clicking rapidly on a login button that doesn't disable itself while a request is
    pending), a cleaner solution would be to handle the new request as if it was a failed reauth and call the state-change
    handler, leaving the state unchanged but providing an Exception so developers can handle/log.
    
    Test Plan:
    - Ran SessionLoginSample, clicked rapidly on Login button in UserSettingsFragment UI, did not see crash (but did see
    Exception being reported via postStateChange)
    - Added unit test, ran unit tests
    
    Revert Plan:
    
    Reviewers: mmarucheck, mingfli, karthiks
    
    Reviewed By: mmarucheck
    
    Differential Revision: https://phabricator.fb.com/D656843
    
    Task ID: 1957947
    authored
  5. Ming Li

    Adding an audience to publish permission requests

    Summary: Add an audience rather than using the default, also fixing some warnings in Eclipse.
    
    Test Plan: tested Scrumptious in emulator.
    
    Reviewers: mmarucheck, clang
    
    Reviewed By: clang
    
    CC: msdkexp@, gregschechte
    
    Differential Revision: https://phabricator.fb.com/D656726
    
    Task ID: 1957997
    authored

Dec 12, 2012

  1. Ming Li

    Fixing erroneous call to uiHelper in SelectionFragment.

    Summary: Fixing the call to be the right method to uiHelper, also adding a check in init() to see if the session is already open, and making the me request there as well (since if it's already open then there won't be a transition).
    
    Test Plan: tested on emulator, ran unit tests.
    
    Reviewers: clang, mmarucheck
    
    Reviewed By: mmarucheck
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D656165
    
    Task ID: 1955361
    authored
  2. clang13

    [android-sdk] Refactor auth code, move reauth validation out of Session.

    Summary:
    Reauthorization validation has been moved out of Session and is only performed now for non-legacy requests,
    via LoginActivity.
    
    Authorization client code has been consolidated into an AuthorizationClient class and moved out of Session and LoginActivity.
    
    Test Plan:
    - Added authorization unit tests
    - Ran all unit tests
    - Ran BooleanOG and Scrumptious with code changes to exercise all auth flavors
     - Display UI, rotate device, cancel
     - Display UI, rotate device, accept
     - Log out, repeat
     - Perform permission upgrade, repeat above steps with reauth UI
    
    Revert Plan:
    
    Reviewers: mmarucheck, mingfli, karthiks
    
    Reviewed By: mingfli
    
    Differential Revision: https://phabricator.fb.com/D655300
    
    Task ID: 1951043
    authored
  3. clang13

    [android-sdk] Localize new strings in SDK

    Summary: Added Spanish/Hebrew localizations of new SDK strings.
    
    Test Plan: Revert Plan:
    
    Reviewers: mmarucheck, mingfli, karthiks
    
    Reviewed By: mmarucheck
    
    Differential Revision: https://phabricator.fb.com/D655331
    
    Task ID: 1944544
    authored
  4. Ming Li

    Fixing test issue.

    Summary: Fixing unit tests to match string in exception thrown.
    
    Test Plan: ran unit tests.
    
    Reviewers: mmarucheck, clang
    
    Reviewed By: clang
    
    Differential Revision: https://phabricator.fb.com/D655722
    
    Task ID: 1939738
    authored
  5. Michael Marucheck

    Fixing selected IntelliJ lint warnings.

    Summary:
    Went through all the IntelliJ lint warnings and picked off any that looked
    like it could possibly have an impact on correctness.
    
    Test Plan: - Unit tests, including one added for double conversion.
    
    Reviewers: clang, mingfli
    
    Reviewed By: mingfli
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D655507
    
    Task ID: 1954931
    authored
  6. Ming Li

    Updating Scrumptious to simplify session handling.

    Summary: Simplify state change handling in Scrumptious to be more decoupled.
    
    Test Plan: Ran on emulator and ensured that session state changes behaves as expected.
    
    Reviewers: mmarucheck, clang
    
    Reviewed By: clang
    
    CC: caabernathy
    
    Differential Revision: https://phabricator.fb.com/D655382
    
    Task ID: 1954737
    authored

Dec 11, 2012

  1. Ming Li

    Fixing some exception messages and making copyright notices more cons…

    …istent.
    
    Summary: Adding "manage" to exception messages that include publish permissions, and making copyright notices more consistent.
    
    Test Plan: builds.
    
    Reviewers: mmarucheck, clang
    
    Reviewed By: mmarucheck
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D655007
    
    Task ID: 1939738
    authored
  2. Michael Marucheck

    Moved legacy support method

    Summary:
    The extendTokenCompleted method is intended to only be used internally.
    To make Session as simple as possible, we are moving this method off
    Session to a static helper in the same package.
    
    Test Plan: - Build, unit tests
    
    Reviewers: clang, mingfli
    
    Reviewed By: mingfli
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D654934
    authored
  3. Ming Li

    Switching over to use properly named app.

    Summary: Switching to a new app so we can change the name from JustRequest to GraphApi
    
    Test Plan: tested on emulator
    
    Reviewers: clang, mmarucheck
    
    Reviewed By: mmarucheck
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D654100
    
    Task ID: 1947284
    authored
  4. Ming Li

    Fix issue with friends not showing up on restart.

    Summary: The issue is that between starts on the emulator, the app itself might not have been destroyed, which causes the Active Session to stick around, which means that on next startup, it starts in the OPENED state, and there's no state change, which normally triggers the load. The fix is to check whether the Active Session is already opened, and to just load the data then and there.
    
    Test Plan: tested on emulator
    
    Reviewers: clang, mmarucheck
    
    Reviewed By: mmarucheck
    
    Differential Revision: https://phabricator.fb.com/D653861
    
    Task ID: 1903570
    authored

Dec 10, 2012

  1. Michael Marucheck

    Doc AuthorizationRequest

    Summary:
    - Added doc for Session.AuthorizationRequest
    - Fixed an eclipse-only warning
    
    Test Plan: - Build/run
    
    Reviewers: clang, mingfli
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D653731
    
    Task ID: 1938802
    authored
  2. Michael Marucheck

    Add @devDocDeprecated tags to deprecated classes

    Summary:
    Deprecating some classes gives warnings when compiling other
    deprecated classes, even with @SuppressWarnings("deprecation").
    This adds a doc-tag that is used when generating online docs
    to mark classes as deprecated even when they are still in use
    by other deprecated classes.
    
    Also moved Util.logd, which is still used in the SDK to
    internal/Utility.logd.
    
    Test Plan:
    - Build all samples
    - Unit tests
    
    Reviewers: clang, mingfli
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D653482
    
    Task ID: 1938802
    authored
  3. Michael Marucheck

    Use fb4a service to try getting token

    Summary:
    Fb4a exposes a service that verifies the signature of the app and
    returns a token with whatever permissions the user has already
    approved.  This uses that service to avoid login UI when permissions
    match.
    
    Test Plan:
    - Manual testing in scrumptious
    
    Revert Plan:
    - safe
    
    Tags:
    
    Reviewers: mingfli, clang
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D652514
    
    Task ID: 1938021
    authored
  4. clang13

    [android-sdk] Some more naming cleanup, primarily LoginFragment -> Us…

    …erSettingsFragment.
    
    Summary:
    For conceptual parity with the iOS SDK, LoginFragment has been renamed to UserSettingsFragment.
    
    FacebookSdkVersion is now package local.
    
    shouldAutoPublishInstall is now an SDK-wide property on Settings rather than Session-specific, again for
    parity with iOS.
    
    Test Plan:
    - Ran unit tests
    - Ran Scrumptious
    
    Revert Plan:
    
    Reviewers: mmarucheck, mingfli, karthiks
    
    Reviewed By: mmarucheck
    
    CC: jacl, ekoneil, caabernathy
    
    Differential Revision: https://phabricator.fb.com/D653411
    
    Task ID: 1950186, 1950192, 1950442
    authored
  5. clang13

    [android-sdk] Request.newPlacesSearchRequest threw exception if no lo…

    …cation was specified.
    
    Summary:
    newPlacesSearchRequest should support specifying either location or searchText (or both), but threw NullPointerException
    if no location was provided. It should also ignore the radiusInMeters parameter if no location is provided.
    
    Test Plan:
    - Added unit test, ran all tests
    
    Revert Plan:
    
    Reviewers: mmarucheck, mingfli, karthiks
    
    Reviewed By: mingfli
    
    Differential Revision: https://phabricator.fb.com/D651768
    
    Task ID: 1944635
    authored
  6. clang13

    [android-sdk] Remove some open* overloads from Session.

    Summary:
    Session had a number of instance and static methods related to opening sessions and active sessions, and it was not
    always clear which one was the right one to use. Removed some of them and renamed others to be clearer about their
    intention.
    
    Test Plan:
    - Ran unit tests
    - Ran samples
    
    Revert Plan:
    
    Reviewers: mmarucheck, mingfli, karthiks, ekoneil
    
    Reviewed By: mingfli
    
    CC: msdkexp@, caabernathy
    
    Differential Revision: https://phabricator.fb.com/D652216
    authored
  7. Ming Li

    Updating javadocs.

    Summary: Updating javadocs for LoginActivity.
    
    Test Plan: builds
    
    Reviewers: mmarucheck, clang, jacl
    
    Reviewed By: mmarucheck
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D652420
    
    Task ID: 1946899
    authored

Dec 07, 2012

  1. clang13

    [android-sdk] Adds RequestBatch-level completion callback; fixes Sess…

    …ion reauth behavior.
    
    Summary:
    Some scenarios involving batched Graph API calls are more cleanly implemented with a completion callback that applies
    to the batch as a whole, rather than individual requests within the batch. This commit adds such a callback to
    RequestBatch.
    
    It also fixes a couple issues with Session and reauthorization. It adds a check to ensure that the access token resulting
    from a reauthorization represents the same Facebook profile as the previous access token did (since users could authenticate
    using different credentials than when the session was originally opened). It also fetches a current list of permissions
    for the user following a reauthorization, to help ensure that the client copy of the permission list stays in sync with
    the service.
    
    Finally, it fixes LoginActivity to pass back the AccessTokenSource of the access token it provides, so we can set it properly.
    
    Test Plan:
    - Added unit tests
    - Ran unit tests
    - Ran Scrumptious, HelloFacebook, and BooleanOG samples
    
    Revert Plan:
    
    Reviewers: mmarucheck, mingfli, karthiks
    
    Reviewed By: mmarucheck
    
    CC: ekoneil, caabernathy
    
    Differential Revision: https://phabricator.fb.com/D647716
    
    Task ID: 1925038, 1925028
    authored
  2. Ming Li

    Fixing NPEs on LoginFragment

    Summary: Reduce the chances of NPEs on LoginFragment (since some calls are just pass-throughs to LoginButton) by setting a properties object that can be created at construction time. Also adding null checks for sessionTracker in the parent fragment class.
    
    Test Plan: Added a unit test to make sure we can call setters in onCreate, tested BooleanOG, and Scrumptious for normal features.
    
    Reviewers: mmarucheck, clang
    
    Reviewed By: mmarucheck
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D650937
    
    Task ID: 1937799
    authored
  3. Ming Li

    Fix dismiss() causing crash when dialog is detached.

    Summary: If dismiss is called (especially on the spinner) after the dialog has been detached from the window, it could cause the whole app to crash. This alleviates that situation. App developers should still call dismiss() on the dialog during onPause() since this does not address the leaking window issue, but if they don't, this at least won't crash their app.
    
    Test Plan: Tested various situations where rotation happens (during a webview load, and after posting an update).
    
    Reviewers: mmarucheck, clang
    
    Reviewed By: mmarucheck
    
    Differential Revision: https://phabricator.fb.com/D643794
    
    Task ID: 1878623
    authored
  4. Ming Li

    Removing FacebookActivity and adding UiLifecycleHelper

    Summary: Removing FacebookActivity and adding a UiLifecycleHelper instead to keep track of the active Session.
    
    Test Plan: Tested all sample apps and ran unit tests.
    
    Reviewers: mmarucheck, clang
    
    Reviewed By: mmarucheck
    
    CC: msdkexp@, subodh
    
    Differential Revision: https://phabricator.fb.com/D649877
    
    Task ID: 1940439
    authored

Dec 06, 2012

  1. Michael Marucheck

    Added note to Facebook.java discouraging its use

    Summary:
    Making the entire Facebook class deprecated causes compiler warnings
    in other deprecated classes.  As an alternative, we have deprecated
    all public members.
    
    Based on feedback, this augments the docstring to make this more
    obvious and adds an explanation of why the class is not deprecated.
    
    Test Plan:
    - build
    
    Revert Plan:
    -safe
    
    Reviewers: ekoneil, mingfli, clang
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D648641
    
    Task ID: 1938802
    authored
Something went wrong with that request. Please try again.