Skip to content
Commits on Mar 21, 2012
  1. @rightparen

    Fixed null pointer issue.

    Summary:
    We need to call unbindService on a Context.  In some cases, mAuthActivity
    is null.  Since applicationsContext is passed in to the constructor
    and never modified, it should not be null.  So we call unbindService
    on applicationsContext instead.
    
    Test Plan: Try SSO with pre-1.8 FB app.
    
    Reviewers: vijaye, jacl, caabernathy
    
    Reviewed By: vijaye
    
    CC: selekman, constantin, lshepard
    
    Differential Revision: https://phabricator.fb.com/D432892
    
    Revert Plan: Safe to revert
    
    Task ID: 982981
    rightparen committed Mar 21, 2012
Commits on Feb 17, 2012
  1. @vijaye

    Disable logging by default

    Summary:
    Logging was turned on unconditionally before, which led to apps leaking
    sensitive data.  This change puts the logging api behind an explicit gate that
    developers have to turn on.
    
    It's unfortunate that this isn't automatic - ideally this would automatically
    turn on for non-release signed bits.  I couldn't find such a check in Android
    framework.  If android experts have better ways of tackling this, i'm all ears.
    But bear in mind this is a security fix and needs to go out asap.
    
    Test Plan: Launched in default mode and verified no logging in emulator.
    Turned on log gate and verified logging.
    
    Reviewers: mmarucheck, lshepard, yariv, raghuc1
    
    Reviewed By: mmarucheck
    
    CC: gregschechte, jacl
    
    Differential Revision: https://phabricator.fb.com/D411377
    
    Task ID: 933141
    vijaye committed Feb 17, 2012
  2. @vijaye

    Fixing Token refresh issue in SDK

    Summary:
    The TokenRefresh intent is exposed as a service, but we were validating it as
    an activity.  Fixign that and refactoring code. This code should have never
    worked.
    
    Note that without the FB app the refresh token feature will not work.  If that
    is necessary, it's not part of this diff.
    
    Test Plan: Verify that hackbook can login & refresh token on the emulator.
    
    Reviewers: mmarucheck, yariv, ttung, raghuc1, trvish, pfung
    
    Reviewed By: mmarucheck
    
    CC: gregschechte, jacl, lshepard
    
    Differential Revision: https://phabricator.fb.com/D410960
    
    Task ID: 926377
    vijaye committed Feb 16, 2012
Commits on Jan 18, 2012
  1. @yariv
Commits on Dec 30, 2011
  1. Added the refresh token method.

    Summary: This allows developers to silently refresh their access token by
    calling Facebook.refreshToken method. This SDK will try to call our Facebook
    Android App which will handle the API call.
    
    Test Plan:
    This requires adding a refresh token service to our sdk. See D364973.
    After that try using the new Hackbook example.
    
    Reviewers: jimbru, raghuc1, brent, dalves, ttung, yariv
    
    Reviewed By: jimbru
    
    CC: dalves, jimbru
    
    Differential Revision: https://phabricator.fb.com/D366540
    
    Task ID: 799996
    Kamil Kraszewski committed with Kamil Kraszewski Dec 1, 2011
Commits on Dec 20, 2011
  1. Update README.md

    dpurdy committed Dec 20, 2011
  2. Update README.md

    dpurdy committed Dec 20, 2011
Commits on Dec 1, 2011
  1. Fixed setAccessExpiresIn method.

    Summary:
    There are two types of access tokens:
     - ones that doesn't expire (expiresIn == 0)
     - ones that have some expiration period( (expiresIn > 0)
    When we receive a new token from FB server for both them we call the
    setAccessExpiresIn method.
    Because of that:
    1. We shouldn't ignore the "0" value
    2. We should also expect tokens that have long expiration period.
    For example 60 days is 2592000000000 miliseconds which is too much for an
    integer variable to handle :)
    
    Test Plan: Tried Login In / Logout for both types of tokens.
    
    Reviewers: jimbru, yariv
    
    Reviewed By: jimbru
    
    CC: kamil, jimbru
    
    Differential Revision: 370353
    Kamil Kraszewski committed with Kamil Kraszewski Nov 30, 2011
  2. Refactoring of Android's Hackbook example

    Summary:
    Cleaning of the Hackbook code. Main reason of this commit is mixing tabs and
    white spaces inside the code, which makes the code ugly (for example browsing
    the code inside github).
    
    In addition I also refactored few other things:
     - I tried to wrap the lines to 100 characters per line (80 per comments) - at
    least in those places where it made sense
     - Remove trailing whitespaces and unnecessary blank lines
     - Add missing @Override adnnotations
     - Fixed syntax in some places (like "for(i=0;..." -> "for (i = 0;...")
     - Added missing 'static' keywords
    
    Test Plan:
    Run the app and see if everything works :-)
    
    Reviewers: jimbru, raghuc1, vksgupta, dalves
    
    Reviewed By: dalves
    
    CC: platform-diffs@lists, nbushak, dalves
    
    Differential Revision: 370079
    Kamil Kraszewski committed with Kamil Kraszewski Nov 30, 2011
Commits on Oct 10, 2011
  1. [android][oauth2] add more descriptive description to invalid_key errors

    Summary:
    This is the android sdk side of D340841.
    
    The hope is that developers will be able to take the key they passed
    in and past it into their application, thus skipping the necessity of
    having keytool and openssl. It also reduces frustration.
    
    Test Plan:
    This requires a change to our sdk :-/, which currently dosn't show error
    descriptions. Anyone
    know how I can push a change to the git repo?
    
    We start with non-useful error message. After applying this and the sdk change,
    we get the
    message
    https://our.intern.facebook.com/intern/pixelcloud/image.php?id=31789
    
    after pasting in our key from the message, sso succeeds
    https://our.intern.facebook.com/intern/pixelcloud/image.php?id=31787
    
    Reviewers: yariv, jimbru, ahimel, brent, lshepard
    
    Reviewed By: jimbru
    
    CC: platform-diffs@lists, ptarjan, naitik, rhe, jimbru, yariv, lshepard
    
    Differential Revision: 341355
    
    Revert Plan: ok
    
    Platform Impact (PUBLIC):
    Android SSO invalid_key failures will now contain the key that
    developers attempted to use.  If this key were to be copied directly
    into the application settings, SSO will work properly for this
    application. This makes it so that developers never have to mess
    around with keytool/openssl. They can just attempt a request with a
    dummy string, then use the error string returned by our endpoint.
    Ray He committed Oct 10, 2011
  2. Hackbook for Android Sample app.

    Summary: The sample app includes SSO, feed and apprequests dialogs, get friends
    via graph or fql, post on friend's wall, get nearby places and check-in to a
    place, upload photo from local media gallery or remote server and Graph API
    Explorer
    
    Test Plan: The sample app can be downloaded from:
    https://developers.facebook.com/attachment/Hackbook.zip. Try it out and lmk if
    code can be optimized or other changes.
    
    Reviewers: lshepard, mattwkelly, dkim, dlim, caabernathy, omids
    
    Reviewed By: dkim
    
    CC: platform-diffs@lists, nbushak, vksgupta, ccwu, erling, dlim, dkim
    
    Differential Revision: 325685
    Vikas Gupta committed Sep 14, 2011
Commits on Oct 7, 2011
  1. Remove the title for dialogs and add the 'x' on the top left corner

    Summary: For the oauth, feed, request dialogs, removed the title bar and added
    the 'x' button on the top left corner which when pressed dismisses the dialog.
    
    Test Plan: Launched Hackbook and click on Login or requests, feed dialogs and
    confirm that there is no title bar and the cross button is rightly displayed and
    dismisses the dialog.
    
    Reviewers: lshepard, yariv, jimbru, dkim, ttung, omids, raghuc1
    
    Reviewed By: ttung
    
    CC: caabernathy, brent, vksgupta, mattwkelly, lshepard, ttung
    
    Differential Revision: 333017
    
    Task ID: 700698
    Vikas Gupta committed Sep 26, 2011
Commits on Mar 17, 2011
  1. @jimbru

    Fix dialog sizing on devices with small (QVGA) screens.

    This fixes dialog sizing on devices with small screens. In particular,
    the bottom buttons will now be visible and no longer hang off the screen.
    jimbru committed Mar 8, 2011
Commits on Feb 2, 2011
Commits on Jan 18, 2011
  1. Add support for a 'state' parameter on async requests.

    This change allows developers to attach an arbitrary object to an asynchronous
    Facebook request that will be returned in the request's callback, which
    should make it easier to distinguish the returns from concurrent requests.
    Jim Brusstar committed Jan 18, 2011
Commits on Dec 22, 2010
  1. Updating Facebook for Android apk to v1.5.0.

    Jim Brusstar committed Dec 21, 2010
Commits on Dec 13, 2010
  1. @jimbru
Commits on Dec 10, 2010
  1. Fixing errors in tests/

    Jim Brusstar committed Dec 9, 2010
Commits on Dec 8, 2010
  1. Fixing whitespace/formatting issues in src/.

    Jim Brusstar committed Dec 7, 2010
  2. Updates to README for platform dialogs.

    Jim Brusstar committed Dec 7, 2010
  3. Add app_id to dialog requests.

    Updated the dialog() method to always include app_id. This will prevent
    an error if a dialog is requested and the application doesn't have an
    access token.
    Jim Brusstar committed Dec 7, 2010
Commits on Dec 2, 2010
  1. Platform Dialogs Support (UIServer Pretty URLs)

    Jim Brusstar committed Nov 16, 2010
Commits on Dec 1, 2010
  1. @bgold

    adding an anchor for dialogs

    bgold committed Nov 30, 2010
Commits on Nov 29, 2010
Commits on Nov 4, 2010
  1. Adding the apk for Facebook Android 1.4.0.

    This is useful for testing single sign-on in the emulator. To install, run:
    
      adb install Facebook.apk
    Luke Shepard committed Nov 3, 2010
  2. Add support for single sign-on to Android SDK

    Summary: This change adds support for "single sign-on" to the Android SDK as announced here: http://developers.facebook.com/blog/post/423
    
    This change is mostly transparent and should require only a few updates to your code. You'll need to modify your code as follows:
    
    * Move your applicationId from the authorize method to the constructor for the Facebook class
    * Insert a call to the authorizeCallback() method at the top of your Activity's onActivityResult() function.
    * Register your Android key hash in the Facebook developer application.
    
    Note that stream dialogs do not yet work with single sign on, but we will add support soon.
    
    For more details, check the README file. If you have issues or bugs, please report them to: https://github.com/facebook/facebook-android-sdk/issues
    
    [ Note: this is a squashed commit with contributions from Yariv Sadan, Jim Brusstar, Arun Vijayvergiya, Brent Goldman, and Luke Shepard]
    Luke Shepard committed Nov 3, 2010
Commits on Sep 30, 2010
  1. Android SDK : Add sdk=android param to dialog and request call

    test plan
    Run Android SDK example, at the same time check the android log. make sure when calling authorize, UIServer stream publish dialog, api call, the log show the url and make sure it contain sdk=android parameter.
    Yujuan Bao committed Sep 30, 2010
Commits on Aug 19, 2010
  1. Add photo upload functionality to Android sdk

    Yujuan Bao committed Aug 18, 2010
Commits on Jun 25, 2010
  1. Add functional test suite to SDK

    Steven Soneff committed Jun 25, 2010
  2. Fix touch redirect issue

    Steven Soneff committed Jun 25, 2010
  3. Revisions to support server-side changes

    Steven Soneff committed Jun 24, 2010
Commits on Jun 23, 2010
  1. Removing the "alpha" label.

    Luke Shepard committed Jun 22, 2010
Commits on Jun 18, 2010
Something went wrong with that request. Please try again.