Integration request for trivial changes in Facebook.java #164

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@nsokolov

These changes intented to preventing WindowLeaked Exception
Also, access level modifiers were changed for DEFAULT_AUTH_ACTIVITY_CODE and validateAppSignatureForIntent to make them accesible from outside of SDK

@nsokolov nsokolov Changes intented to preventing WindowLeaked Exception
Also, access level modifiers were changed for DEFAULT_AUTH_ACTIVITY_CODE
and validateAppSignatureForIntent to make them accesible
from outside of SDK
004acc7
@loopj

Facebook: PLEASE merge these in to master, we're seeing hundreds of these exceptions in the wild. Thanks nsokolov!

@arthurdamm

Agreed, also dealing with these exceptions at orientation change.

@jamesgpearce
Facebook member

This pull request was raised against a previous version of the Facebook SDK for Android.

In 2012, the SDK had a significant rewrite and relaunch, and we are closing issues and pull requests that predate that v3.0 release.

If you think this pull request is still relevant, please refactor it to apply to the supported SDK (currently v3.6). For more information, please see our Android developer center at https://developers.facebook.com/docs/android

Many thanks for using the Facebook Platform, and your support of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment