New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 2.1 - Fixed NullpointerException when request timeout while down... #389

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@cristianoliveira
Contributor

cristianoliveira commented Oct 12, 2014

Fixed NullpointerException on InputStreamReader when request timeout while downloading images.

This issue has occurred on Android 2.1 in Motorola Defy.

More details can be found in http://ivokee.com/log_error/show_all

Trace:
java.lang.NullPointerException at java.io.Reader.(Reader.java:65) at java.io.InputStreamReader.(InputStreamReader.java:65) at com.facebook.internal.ImageDownloader.download(ImageDownloader.java:248) at com.facebook.internal.ImageDownloader.access$1(ImageDownloader.java:205) at com.facebook.internal.ImageDownloader$DownloadImageWorkItem.run(ImageDownloader.java:356) at com.facebook.internal.WorkQueue$1.run(WorkQueue.java:118) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1068) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:561) at java.lang.Thread.run(Thread.java:1096)

Thanks
Cristian Oliveira

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Oct 12, 2014

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented Oct 12, 2014

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Oct 12, 2014

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented Oct 12, 2014

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gcaglar

View changes

Show outdated Hide outdated facebook/src/com/facebook/internal/ImageDownloader.java Outdated
@gcaglar

View changes

Show outdated Hide outdated facebook/src/com/facebook/internal/ImageDownloader.java Outdated
@cristianoliveira

This comment has been minimized.

Show comment
Hide comment
@cristianoliveira

cristianoliveira Oct 18, 2014

Contributor

Hi Caglar.

Thanks for yours advices.
I will do that and send new PR to the dev branch!

Cristian Oliveira.

Contributor

cristianoliveira commented Oct 18, 2014

Hi Caglar.

Thanks for yours advices.
I will do that and send new PR to the dev branch!

Cristian Oliveira.

@cristianoliveira cristianoliveira deleted the cristianoliveira:master branch Oct 18, 2014

@cristianoliveira cristianoliveira restored the cristianoliveira:master branch Oct 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment