Please sign in to comment.
Use localized collation in friend picker
Summary: this diff changes FBGraphObjectTableDataSource to support collation, so that names are categorized and displayed properly based on the locale of the app. I've replicated functionality as is present in other FB apps, namely: display collation index on the right, don't show section headers and collation index if there's too few rows, omit empty section headers, ensure correct lookup from right side (section index) to left side (section titles). This is also consistent with the Contacts built-in app and the iOS HIG. Test Plan: Use Friend picker sample on various localizations (had to add supported locales to its info.plist), ensure collation is displayed correctly. Ensure tapping on letters in the section index shows the correct section. Ensure selecting rows in the table and tapping "Done" returns correct results to the caller. Screenshots: Before: http://www.facebook.com/pxlcld/8qWl After: English: http://www.facebook.com/pxlcld/8qWm Russian: http://www.facebook.com/pxlcld/8qV6 Japanese: http://www.facebook.com/pxlcld/8qVd Too few contacts: Before: http://www.facebook.com/pxlcld/8qWf After: http://www.facebook.com/pxlcld/8qWs Reviewers: jacl, jketchpaw, vijaye, suhas Reviewed By: jacl CC: platform-diffs@lists, msdkexp@ Differential Revision: https://phabricator.fb.com/D547860 Task ID: 1354966
- Loading branch information...
Showing with 139 additions and 46 deletions.
Oops, something went wrong.