Skip to content
Browse files

Facebook iOS SDK 3.5.3

Summary:
     Bug fixes. See https://developers.facebook.com/ios/change-log-3.x/

Reviewed By: jacl

Test Plan: Release Testing.

@update-submodule: vendor/OCMock
  • Loading branch information...
1 parent 56b40a4 commit acd4f57e7781dad4ffebcf658d56f96abfd96c1a @chrisp-fb chrisp-fb committed
View
2 scripts/build_distribution.sh
@@ -96,7 +96,7 @@ $PACKAGEMAKER \
--target 10.5 \
--version $FB_SDK_VERSION \
--out $FB_SDK_PKG \
- --title 'Facebook SDK 3.5.2 for iOS' \
+ --title 'Facebook SDK 3.5.3 for iOS' \
|| die "PackageMaker reported error"
if [ ! "$CODE_SIGN_IDENTITY" ]; then
View
2 scripts/build_documentation.sh
@@ -45,7 +45,7 @@ rm -rf $DOCSET
hash $APPLEDOC &>/dev/null
if [ "$?" -eq "0" ]; then
- APPLEDOC_DOCSET_NAME="Facebook SDK 3.5.2 for iOS"
+ APPLEDOC_DOCSET_NAME="Facebook SDK 3.5.3 for iOS"
$APPLEDOC --project-name "$APPLEDOC_DOCSET_NAME" \
--project-company "Facebook" \
--company-id "com.facebook" \
View
1 scripts/build_framework.sh
@@ -74,6 +74,7 @@ cd $FB_SDK_SRC
function xcode_build_target() {
echo "Compiling for platform: ${1}."
$XCODEBUILD \
+ RUN_CLANG_STATIC_ANALYZER=NO \
-target "facebook-ios-sdk" \
-sdk $1 \
-configuration "${2}" \
View
2 src/FBNativeDialogs.m
@@ -42,7 +42,7 @@ + (FBOSIntegratedShareDialogHandler)handlerFromHandler:(FBShareDialogHandler)han
FBOSIntegratedShareDialogHandler fancy = ^(FBOSIntegratedShareDialogResult result, NSError *error) {
handler(result, error);
};
- return fancy;
+ return [[fancy copy] autorelease];
}
return nil;
}
View
2 src/FBRequest.m
@@ -323,7 +323,7 @@ + (FBRequest *)requestForPostOpenGraphObjectWithType:(NSString *)type
}
+ (FBRequest *)requestForUpdateOpenGraphObject:(id<FBOpenGraphObject>)object {
- return [FBRequest requestForUpdateOpenGraphObjectWithId:object.id graphObject:object];
+ return [FBRequest requestForUpdateOpenGraphObjectWithId:object[@"id"] graphObject:object];
}
+ (FBRequest *)requestForUpdateOpenGraphObjectWithId:(id)objectId
View
4 src/FBRequestConnection.m
@@ -599,14 +599,14 @@ - (void)startWithCacheIdentity:(NSString*)cacheIdentity
- (void)startURLConnectionWithRequest:(NSURLRequest *)request
skipRoundTripIfCached:(BOOL)skipRoundTripIfCached
completionHandler:(FBURLConnectionHandler) handler {
- FBURLConnection *connection = [[self createFBURLConnection] initWithRequest:request
+ FBURLConnection *connection = [[self newFBURLConnection] initWithRequest:request
skipRoundTripIfCached:skipRoundTripIfCached
completionHandler:handler];
self.connection = connection;
[connection release];
}
-- (FBURLConnection *)createFBURLConnection {
+- (FBURLConnection *)newFBURLConnection {
return [FBURLConnection alloc];
}
View
2 src/FBSDKVersion.h
@@ -1,2 +1,2 @@
-#define FB_IOS_SDK_VERSION_STRING @"3.5.2"
+#define FB_IOS_SDK_VERSION_STRING @"3.5.3"
#define FB_IOS_SDK_MIGRATION_BUNDLE @"fbsdk:20130409"
View
2 src/facebook-ios-sdk.xcodeproj/project.pbxproj
@@ -1492,6 +1492,7 @@
INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
PRODUCT_NAME = facebook_ios_sdk;
PUBLIC_HEADERS_FOLDER_PATH = "$(TARGET_NAME)";
+ RUN_CLANG_STATIC_ANALYZER = YES;
SDKROOT = iphoneos;
SKIP_INSTALL = YES;
};
@@ -1510,6 +1511,7 @@
INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
PRODUCT_NAME = facebook_ios_sdk;
PUBLIC_HEADERS_FOLDER_PATH = "$(TARGET_NAME)";
+ RUN_CLANG_STATIC_ANALYZER = YES;
SDKROOT = iphoneos;
SKIP_INSTALL = YES;
};
View
4 src/tests/FBRequestConnectionTests.m
@@ -32,7 +32,7 @@ - (BOOL)shouldExtendAccessToken;
@interface FBRequestConnection (Testing)
-- (FBURLConnection *)createFBURLConnection;
+- (FBURLConnection *)newFBURLConnection;
@end
@@ -51,7 +51,7 @@ - (void)testWillNotPiggybackIfWouldExceedBatchSize
// Swizzle the connection not actually send any requests; we don't care what happens to the requests.
FBURLConnection *mockURLConnection = [OCMockObject niceMockForClass:[FBURLConnection class]];
FBRequestConnection *swizzledConnection = [OCMockObject partialMockForObject:connection];
- [[[(id)swizzledConnection expect] andReturn:mockURLConnection] createFBURLConnection];
+ [[[(id)swizzledConnection expect] andReturn:mockURLConnection] newFBURLConnection];
const int batchSize = 50;
for (int i = 0; i < batchSize; ++i) {
2 vendor/OCMock
@@ -1 +1 @@
-Subproject commit 3a377e6120d30fc39eeed6ec35eea472ac02ef79
+Subproject commit d7c45c4b0d7b8b285a597502d3938640bd751299

0 comments on commit acd4f57

Please sign in to comment.
Something went wrong with that request. Please try again.