Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jun 19, 2012
  1. @clang13

    [ios-sdk] Fix docs/distribution scripts

    clang13 authored
    Summary:
    Appledoc docset name was referenced twice, and differently. Fixed to use the variable set by common.sh, and fixed
    common.sh to set the right name.
    
    Test Plan: Revert Plan:
    
    Reviewers: jacl
    
    Reviewed By: jacl
    
    Differential Revision: https://phabricator.fb.com/D497697
Commits on Jun 18, 2012
  1. @clang13

    [ios-sdk] Fix label script

    clang13 authored
    Summary: Need to pass -a to git tag because repo requires annotated tags.
    
    Test Plan: Revert Plan:
    
    Reviewers: jacl
    
    Reviewed By: jacl
    
    Differential Revision: https://phabricator.fb.com/D497679
  2. @clang13

    [ios-sdk] Fix two leaks

    clang13 authored
    Summary: Found two leaks running under Instruments. Fixed them.
    
    Test Plan:
    - Ran SwitchUserSample and Scrumptious, did not see these leaks
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D497631
  3. @onebit

    Makes object lifetime handling more crisp in JustRequest

    onebit authored
    Summary:
    This fix is not strictly addressing a leak, but it does release memory more
    aggressively which makes it easier to tack memory use in general
    
    Test Plan: Ran sample
    
    Reviewers: clang, mmarucheck, caabernathy
    
    Reviewed By: clang
    
    CC: gregschechte, ekoneil
    
    Differential Revision: https://phabricator.fb.com/D497632
    
    Task ID: 1011836
  4. @onebit

    Adds instructive comments to FriendPicker and PlacePicker sample, fix…

    onebit authored
    …es design flaw in respective controls
    
    Summary:
    The instructive text explains itself. The design flaw is that the view controller defaulted its delegate to
    self. The fix is to default this to nil, and have the related samples be more explicit about setting the delegate
    
    Test Plan: Ran samples and unit tests
    
    Reviewers: clang, mmarucheck, caabernathy
    
    Reviewed By: clang
    
    CC: gregschechte, ekoneil
    
    Differential Revision: https://phabricator.fb.com/D497407
    
    Task ID: 1011836
  5. @clang13

    [ios-sdk] Pre-fetch places in Scrumptious, don't refresh location on …

    clang13 authored
    …small changes.
    
    Summary:
    When we get a valid location in Scrumptious, we now pre-fetch the cache so the next usage of the
    place picker will be fast. We also don't want to get notified of small (<50m) changes in location as
    this would tend to kill our use of the cache.
    
    Test Plan:
    - Ran Scrumptious
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    Differential Revision: https://phabricator.fb.com/D497449
  6. @clang13

    [ios-sdk] Added comments to Scrumptious sample.

    clang13 authored
    Summary:
    More descriptive comments for Scrumptious.
    
    Made a minor change to the logic in the app delegate to be more explicit about when an error occurred.
    
    Test Plan:
    - Ran sample, still works
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden, caabernathy
    
    Reviewed By: jacl
    
    Differential Revision: https://phabricator.fb.com/D497362
  7. @clang13

    [ios-sdk] Fix Scrumptious photo functionality on iPad

    clang13 authored
    Summary:
    An earlier change broke Scrumptious on the iPad. Image picker needs to be displayed differently on iPad, and it
    was not being called correctly.
    
    Test Plan:
    - Ran in iPad and iPhone simulator
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    Differential Revision: https://phabricator.fb.com/D497326
  8. @clang13

    [ios-sdk] Work around appledoc bug that dropped protocol from propert…

    clang13 authored
    …y declarations.
    
    Summary:
    Appledoc has a bug that caused the protocol name to be dropped from property declarations, leaving
    them looking like 'id<> delegate' rather than 'id<SomeProtocol> delegate'. Until the bug gets fixed,
    hacking around it by explicitly replacing the wrong string with the right string.
    
    Test Plan:
    - Ran build_documentation.sh, looked at resulting HTML, saw protocol names
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden, caabernathy
    
    Reviewed By: jacl
    
    Differential Revision: https://phabricator.fb.com/D497310
  9. @onebit

    Adds production art for Scrumptious and Just Login

    onebit authored
    Summary: We had place-holder art here, which this diff removes in favor of production art
    
    Test Plan: Ran samples
    
    Reviewers: clang, mmarucheck, caabernathy
    
    Reviewed By: clang
    
    CC: gregschechte, ekoneil, klyi
    
    Differential Revision: https://phabricator.fb.com/D497216
    
    Task ID: 1011836
  10. @clang13

    [ios-sdk] Add icons to samples.

    clang13 authored
    Summary:
    We got sweet new icons for the SDK samples. Added them to the sample projects, except for Scrumptious and JustLoginSample,
    which @jacl has a commit ready for.
    
    Test Plan:
    - Ran samples in simulator, observed sweet new icons.
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    Differential Revision: https://phabricator.fb.com/D497209
  11. @caabernathy

    Reference document improvements.

    caabernathy authored
    Summary: Expanded comments, language cleanup.
    
    Test Plan:
    Run build_documentation.sh, then moved files to proper place so they showed up in Xcode organizer and verified improvements.
    
    Revert Plan:
    OK
    
    Reviewers: jacl
    
    Reviewed By: jacl
    
    CC: clang, mmarucheck, ayden, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D497094
  12. @onebit

    Improves comments and documentation of Switch User sample application

    onebit authored
    Summary: As the title suggests, expanding comments in the Switch User sample
    
    Test Plan: Ran the app to make sure I didn't break it
    
    Reviewers: clang, mmarucheck, caabernathy
    
    Reviewed By: caabernathy
    
    CC: gregschechte, ekoneil
    
    Differential Revision: https://phabricator.fb.com/D496987
    
    Task ID: 1011836
  13. @onebit

    Same basic docs improvements for FBGraphObject, FBOpenGraphAction, an…

    onebit authored
    …d FBSessionTokenCachingStrategy
    
    Summary: see title
    
    Test Plan: Built docs, looked at them
    
    Reviewers: clang, mmarucheck, caabernathy
    
    CC: gregschechte, ekoneil, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D497068
    
    Task ID: 1011836
  14. @onebit

    Improves comments and small cleanup for ProfilePictureSample

    onebit authored
    Summary: per title
    
    Test Plan: Ran the sample
    
    Reviewers: clang, mmarucheck
    
    Reviewed By: mmarucheck
    
    Differential Revision: https://phabricator.fb.com/D496913
    
    Task ID: 1011836
  15. @onebit

    Adds a bit more content and explanation to the comments in MyProfile …

    onebit authored
    …sample
    
    Summary: see title
    
    Test Plan: Ran sample
    
    Reviewers: clang, mmarucheck, caabernathy, gregschechte
    
    Reviewed By: gregschechte
    
    CC: gregschechte, ekoneil
    
    Differential Revision: https://phabricator.fb.com/D496965
    
    Task ID: 1011836
Commits on Jun 17, 2012
  1. @onebit

    Adds brace, space, and argument stacking formatting consistency for s…

    onebit authored
    …amples
    
    Summary: see title
    
    Test Plan: Ran samples
    
    Reviewers: clang, mmarucheck, caabernathy
    
    Reviewed By: clang
    
    Differential Revision: https://phabricator.fb.com/D496697
    
    Task ID: 1011836
  2. @onebit

    Switches the name to the final name in various places

    onebit authored
    Summary: see title
    
    Test Plan: Ran a clean build distribution
    
    Reviewers: clang, mmarucheck
    
    Reviewed By: clang
    
    CC: gregschechte, ekoneil, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D496757
    
    Task ID: 1094634
  3. @caabernathy

    FBPlacePickerViewController comment changes for reference documentati…

    caabernathy authored
    …on improvements.
    
    Summary: Expanded comments, language cleanup. Changes similar to those done for the friend picker view controller header file.
    
    Test Plan:
    Run build_documentation.sh, then moved files to proper place so they showed up in Xcode organizer and verified improvements.
    
    Revert Plan:
    OK
    
    Reviewers: jacl
    
    CC: clang, mmarucheck, ayden
    
    Differential Revision: https://phabricator.fb.com/D496404
  4. @onebit

    Work-around for a location-service bug in the simulator

    onebit authored
    Summary:
    After bumping into the bug discussed here -- http://stackoverflow.com/questions/7003155/error-server-did-not-accept-client-registration-68
    added a check for a 0,0 location, and sets the coordinates near the Eiffel Tower, in order to show something rather than an empty list
    
    Test Plan: ran scrumptious
    
    Reviewers: clang, mmarucheck
    
    Reviewed By: clang
    
    CC: gregschechte, ekoneil, klyi
    
    Differential Revision: https://phabricator.fb.com/D496769
    
    Task ID: 1011836
Commits on Jun 15, 2012
  1. @clang13

    [ios-sdk] Better serialiation of NSDate and NSNumber properties.

    clang13 authored
    Summary:
    We were not serializing NSDate or NSNumber objects in Graph API requests. Since we convert number-ish
    things to NSNumber on deserialization, this was a problem for round-tripping objects. Likewise for NSDate,
    which we do not produce on deserialization, but which are a natural thing for developers to want to use
    for creating objects with date/timestamps.
    
    Removed adding a place tag to OG Action tests because it depends on developers' unit-test app being approved for
    tagging, which is an extra burden and doesn't add much to the value of the test.
    
    Test Plan:
    - Ran unit tests under 4.3 and 5.1
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D496047
    
    Task ID: 1109758
  2. @onebit

    Adds second table and improves comments for the BooleanOG sample

    onebit authored
    Summary: see title
    
    Test Plan: Ran sample
    
    Reviewers: clang, mmarucheck
    
    Reviewed By: clang
    
    CC: gregschechte, ekoneil
    
    Differential Revision: https://phabricator.fb.com/D495926
    
    Task ID: 1011836
  3. @caabernathy

    FBFriendPickerViewController comment changes for reference documentat…

    caabernathy authored
    …ion improvements.
    
    Summary: Expanded comments, language cleanup.
    
    Test Plan:
    Run build_documentation.sh, then moved files to proper place so they showed up in Xcode organizer and verified improvements. Also ran unit tests to make sure nothing broken.
    
    Revert Plan:
    OK
    
    Reviewers: jacl
    
    Reviewed By: jacl
    
    CC: clang, mmarucheck, ayden
    
    Differential Revision: https://phabricator.fb.com/D495850
  4. @caabernathy

    FBRequest comment changes for reference documentation improvements

    caabernathy authored
    Summary: Fix some comments that were showing up as code, add more content, some cleanup.
    
    Test Plan:
    Run build_documentation.sh, then moved files to proper place so they showed up in Xcode organizer and verified improvements.
    
    Revert Plan:
    
    Tags
    
    Reviewers: jacl
    
    Reviewed By: jacl
    
    CC: clang, mmarucheck, ayden
    
    Differential Revision: https://phabricator.fb.com/D495105
  5. @clang13

    [ios-sdk] Don't have ginormous stretched spinner in iOS 4.3.

    clang13 authored
    Summary:
    On iOS 4.3, the spinner being displayed in graph object table cells was a
    MondoSpinner(tm) the width of the entire display. The world is not yet ready for
    MondoSpinner(tm), so it is being replaced with a normal-size spinner. The autoresizing
    mask flags apparently are interpreted differently on 4.3 and later iOSes. Fixed to not
    autosize the spinner, but rather calculate where it should be placed and explicitly set
    its center point.
    
    Also cleaned up some math in FBUtility after discovering the CGRectGetMidX/Y function.
    
    Test Plan:
    - Ran place/friend picker samples on 4.3 and 5.0, verified that spinners are all normal size.
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D495067
    
    Task ID: 1123885
  6. @clang13

    [ios-sdk] Prepare Scrumptious for App Store review.

    clang13 authored
    Summary:
    In preparation for sending Scrumptious to Apple for review:
    - Build for armv6 as well as armv7
    - Add "user_generated" tag to action image (and fix FBRequestConnection.m to be
      slightly more accepting when figuring out whether a path is an OG action)
    - Set Scrumptious target to 4.3
    
    Test Plan:
    - Ran Scrumptious, uploaded a picture larger than 520x520px
    - Went to Facebook.com, saw big picture rather than thumbnail in action
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, ayden, gregschechte
    
    Reviewed By: jacl
    
    Differential Revision: https://phabricator.fb.com/D495073
    
    Task ID: 1043675, 1089624
  7. @clang13

    [ios-sdk] Fix unit tests, two other bugs

    clang13 authored
    Summary:
    Apparently either the Lincoln Memorial moved, our place data changed, or our distance algorithm
    changed, since our queries that used to work with a 100m radius now require a 200m radius to
    return the expected results.
    
    FBRequestConnection was not properly nil-ing an NSError pointer prior to passing it by reference
    down the stack. This caused inconsistent behavior in error handling depending on what happened with
    previous requests.
    
    Always upper-case HTTPMethod names before setting them on NSURLRequest, as HTTP standard says they are
    case-sensitive and FB servers will reject requests with, e.g., lower-case methods.
    
    Made FBTestSession shouldExtendAccessToken faker be one-shot rather than always saying "yes", to avoid
    infinite (until the test session ends) loop if token extension failed.
    
    Removed two helpers from FBTests that caused more harm than good because they made it too easy to write tests
    that didn't wait for blockers, giving nondeterministic results as whether a test succeeded or failed depended
    on timing patterns.
    
    Test Plan:
    - Ran unit tests, all passed under 4.3, 5.0, 5.1
    - Ran Scrumptious, worked correctly
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D495517
    
    Task ID: 1125562, 1125563
Commits on Jun 14, 2012
  1. @onebit

    Adds caching support for place picker

    onebit authored
    Summary: Adds API and internal support for caching of the place picker.
    
    Test Plan: Whitebox via custom version of PlacesPicker sample, long-term testing via scrumptious once support is there
    
    Reviewers: clang, mmarucheck
    
    Reviewed By: clang
    
    CC: gregschechte, yariv
    
    Differential Revision: https://phabricator.fb.com/D494657
    
    Task ID: 1093164
  2. @caabernathy

    FBSession comment changes for reference documentation improvements

    caabernathy authored
    Summary: Fix some comments that were showing up as code, add more content, some cleanup.
    
    Test Plan:
    Run build_documentation.sh, then moved files to proper place so they showed up in Xcode organizer and verified improveme
    
    Revert Plan:
    
    Reviewers: jacl
    
    Reviewed By: jacl
    
    CC: clang, mmarucheck, ayden
    
    Differential Revision: https://phabricator.fb.com/D494662
  3. @onebit

    Improves error handling and message for FBRequestConnections to endpo…

    onebit authored
    …ints that return images
    
    Summary:
    Fixes caching bug, and checks for known unsupported mime types, in order to improve error
    handling if an app points to a graph API that returns an image
    
    Test Plan: Whitebox tested using a modified profile picker sample
    
    Reviewers: clang, mmarucheck, gregschechte
    
    Reviewed By: clang
    
    Differential Revision: https://phabricator.fb.com/D494125
    
    Task ID: 1011836
  4. Implemented camera feature and action sheet for Scrumptious

    k8 authored
    Summary: added an action sheet to choose taking photo from camera or from photos on phone, fixed camera functionality
    
    Test Plan: run scrumptious
    
    Reviewers: clang, ysung
    
    Reviewed By: clang
    
    Differential Revision: https://phabricator.fb.com/D493780
    
    Blame Revision: :
    
    Task ID: 1115172
Commits on Jun 13, 2012
  1. @onebit

    Addresses 4.3 compilation problem in two samples

    onebit authored
    Summary:
    Switches to strong references to conform to 4.3 feature set for two samples, as well
    as switches the remaining projects to target 4.3
    
    Test Plan: Ran the modified samples to confirm behavior
    
    Reviewers: clang, mmarucheck
    
    Reviewed By: mmarucheck
    
    Differential Revision: https://phabricator.fb.com/D493363
    
    Task ID: 1011836
  2. @clang13

    [ios-sdk] Hide spinner after first page of places picker results.

    clang13 authored
    Summary:
    I missed this change in the earlier caching diff. Since places picker only loads
    data a page at a time, until the user scrolls down to the end, we want to hide the
    spinner after each page load, rather than only when "finished" (which only happens if
    the user scrolls all the way to the end of all available results).
    
    Test Plan:
    - Ran PlacesPickerSample, verified that spinner went away after the first page of
    results is loaded (it didn't before this fix).
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    Differential Revision: https://phabricator.fb.com/D493232
    
    Task ID: 1121105
  3. @rightparen

    Fix cache index update

    rightparen authored
    Summary:
    FBCacheIndex applied parameters to the SQL statement in the wrong
    order for the updateQuery.  This resulted in keeping an old entry
    around that referred to a file that had been deleted.  So on the
    next boot, we would check for the file and not find it.  This did
    not affect creating new entries, so we did not notice this until
    recently.
    
    Test Plan:
    - build_all.sh
    - in Scrumptious, boot once and wait a while so the cache is
      initialized.  Kill the program, and then start it again.  When
      the entry screen appears, quickly click on "With whom?" to
      see friend picker before the round-trip.
    
    Revert Plan:
    Safe
    
    Reviewers: clang, jacl
    
    Reviewed By: clang
    
    Differential Revision: https://phabricator.fb.com/D493317
    
    Task ID: 1121111
  4. @clang13

    [ios-sdk] Replace doc generation with appledoc.

    clang13 authored
    Summary:
    appledoc is an open-source documentation generator that generates docs
    with a style similar to the Apple documentation and that can easily integrate
    with Xcode.
    
    Updated build_documentation.sh to use appledoc if installed, and error if not.
    
    Updated build_distribution.sh to install docset in package/Library/Developer/Shared/...
    so it will be installed into user's Xcode docs directory.
    
    Test Plan:
    - Blew away build directory and any Facebook dirs under ~/Library/Developer/Shared
    - Ran build_distribution.sh
    - Installed package
    - Ran Xcode
    - Verified "Facebook iOS SDK" is shown in Organizer
    
    Reviewers: jacl, mmarucheck, gregschechte, ekoneil
    
    Reviewed By: jacl
    
    CC: caabernathy, platform-diffs@lists, yariv
    
    Differential Revision: https://phabricator.fb.com/D490657
    
    Task ID: 1113291
Something went wrong with that request. Please try again.