Summary: 1) removes period 2) adds 's' Test Plan: Sat back, reflected for a moment on why details like these bug me. Reviewers: clang, mmarucheck, gregschechte Reviewed By: clang CC: msdkexp@ Differential Revision: https://phabricator.fb.com/D515714 Task ID: 1011836
Summary: 1) simplifies the readme, and points users to Hello Facebook 2) Uses "Log In" and "Log Out" in FBLoginView Test Plan: Built & ran Reviewers: clang, gregschechte Reviewed By: clang CC: msdkexp@ Differential Revision: https://phabricator.fb.com/D515487 Task ID: 1011836
Summary: Added a README file, identical to the README.mdown, but less scary to people who don't know what an .mdown file is. Added basic Getting Started steps to the README, and redirecting to the web Getting Started for richer docs. Displaying the README on the final page of the Installer as well as the first one, to give developers another change to read it before dismissing the installer. Test Plan: - Ran the installer Revert Plan: Reviewers: jacl, mmarucheck, ayden, gregschechte Reviewed By: gregschechte CC: msdkexp@ Differential Revision: https://phabricator.fb.com/D510247
Summary: Update FriendPickerSample as discussed to: - No longer derive a new view controller for friend picker - Build the sample as a UINavigationController-based sample - Support the Cancel/Done UI that fbiphone/wilde use Test Plan: IMO this is both more straightforward and more akin to expected usage. However, it's definitely still a bit tricky primarily due to the setup of the UINavigationController. I think that's expected, though, since it's not the job of our sample to make the UI navigation paradigms in iOS easier to program generally. I didn't pursue the "modeless" example like what Eddie showed in email. While the content control can certainly be put to that use, I really think we need to have these samples be single purpose/single-use and relatively simple. Key code to review is the mods in FPAppDelegate.m and FPViewController.m. It is admittedly a bit odd that the Done/Cancel UI, applied to the friend picker controller, are inserted in the sample app because the sample is the one creating the nav controller. I think it's correct, though, from what I read on all of this. Note that I haven't yet made a pass to update to new session convenience methods. Will do that after an initial review here. Test Plan: Ran both iPhone and iPad on my box. Lots of Cancel, Done, friend choosing, etc. Reviewers: jacl, clang, ekoneil Reviewed By: clang CC: msdkexp@ Differential Revision: https://phabricator.fb.com/D505528 Task ID: 1141720
Summary: Appledoc docset name was referenced twice, and differently. Fixed to use the variable set by common.sh, and fixed common.sh to set the right name. Test Plan: Revert Plan: Reviewers: jacl Reviewed By: jacl Differential Revision: https://phabricator.fb.com/D497697
Summary: see title Test Plan: Ran a clean build distribution Reviewers: clang, mmarucheck Reviewed By: clang CC: gregschechte, ekoneil, platform-diffs@lists Differential Revision: https://phabricator.fb.com/D496757 Task ID: 1094634
Summary: * Removed template files, fixed up build to no longer reference it. * Basically removed almost all of the README in favor of a link to the proper landing page on facebook.com Task ID: #1106265 Test Plan: Built on my system. Reviewers: mmarucheck, clang, jacl Reviewed By: mmarucheck CC: msdkexp@ Differential Revision: https://phabricator.fb.com/D486116
Summary: Updates to README.mdown for samples, creating project, and template. Take a look to see what changed. Test Plan: Built distribution and looked at result in the .pkg installer. Reviewers: mmarucheck, jacl, clang Reviewed By: jacl CC: msdkexp@ Differential Revision: https://phabricator.fb.com/D473210 Revert Plan: revert
not include .pkg.
Summary: See title Test Plan: build Reviewers: jacl, vijaye Reviewed By: jacl Differential Revision: https://phabricator.fb.com/D444811 Revert Plan: safe Task ID: 1012470
Summary: Updated ReadMe.txt and put them in setup. Fixed multi-request. There were a couple issues. We were not adding requestElements to the batch. Also, I had not realized that batch results are returned as an array of dictionaries, where each dictionary has a "body" property. The property is a string of JSON rather than a JSON object. Test Plan: - JustRequestSample using single and multiple ids. - Hackbook Reviewers: jacl, vijaye Reviewed By: vijaye CC: security-diffs@lists Differential Revision: https://phabricator.fb.com/D444713 Revert Plan: Safe to revert Task ID: 1012470
…gate changes. Add notice on issue reporting.