Skip to content
Commits on Jul 25, 2012
  1. Refactors statics on FBRequest and FBRequestConnection

    Jason Clark committed Jul 25, 2012
    Summary:
    Moves some statics around and adds a few helpers, in order to make
    FBRequest and FBRequestConnection more cohesive and helpful.
    
    Test Plan: updated samples, built, ran related methods
    
    Reviewers: clang, ekoneil, mmarucheck, gregschechte, caabernathy
    
    Reviewed By: clang
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D530267
    
    Task ID: 1235919
  2. @clang13

    [ios-sdk] Added presentModally method to FBViewController, don't auto…

    clang13 committed Jul 23, 2012
    …-add controls when loaded from NIB
    
    Summary:
    FBViewController was automatically adding controls to views loaded from a NIB, which is a bad idea as we may
    end up invalidating custom layouts, etc., that the caller wishes to preserve. We now only automatically add a
    Done or Cancel button (and corresponding toolbar) when being created programmatically via init. If doneButton
    or cancelButton is wired up via NIB, we ensure their target is set correctly so we can handle them.
    
    Added a new presentModallyFromViewController:animated:handler: method that provides a one-line way to call
    a picker and, if Done is pressed, handle that case.
    
    Updated HelloFacebook to use non-wrapped modal friend picker.
    
    Updated HiFacebook to use wrapped modal friend picker.
    
    Test Plan:
    - Ran Scrumptious
    - Ran HelloFacebook, HiFacebook
    - Ran PlacePickerSample, FriendPickerSample
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D527809
  3. Removes FBMyData and related code

    jasonclark committed Jul 25, 2012
    Summary:
    At this time we are uncertain whether FBMyData is the right abstraction
    for the simple integration case. We are pulling it for the next release,
    and will reevaluate it down the road.
    
    Test Plan: built the world
    
    Reviewers: clang, mmarucheck, gregschechte, ekoneil
    
    Reviewed By: ekoneil
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D530075
    
    Task ID: 1235919
Commits on Jul 24, 2012
  1. @laughingguitarist

    Fixing the bug in Task #1132271 by making sure that PPViewController …

    laughingguitarist committed Jul 23, 2012
    …updates the view when an empty data set is returned
    
    Summary: Fixing the bug by making sure that PPViewController updates the view when an empty data set is returned
    
    Test Plan: Tested various queries and query scopes on both iPhone and iPad emulators
    
    Reviewers: gregschechte, clang, jacl, mmarucheck
    
    Reviewed By: clang
    
    CC: jbinney
    
    Differential Revision: https://phabricator.fb.com/D528004
    
    Task ID: 1132271
Commits on Jul 23, 2012
  1. @clang13

    [ios-sdk] Fix FBViewController to put its canvas view behind any cust…

    clang13 committed Jul 20, 2012
    …om UI.
    
    Summary:
    canvasView was in front of UI being loaded from, e.g., a NIB, causing them not to receive UI events. Moved
    it to the back so UI elements on top of it get events.
    
    Test Plan:
    - Ran Scrumptious, PlacePickerSample, (not committed) ViewControllersSample
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D526653
Commits on Jul 20, 2012
  1. @onebit

    Minor doc fixes

    onebit committed Jul 20, 2012
    Summary: See title
    
    Test Plan: built framework and docs
    
    Reviewers: clang, ayden
    
    Reviewed By: ayden
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D526482
    
    Task ID: 1132284
  2. @onebit

    Adds high-level FBMyData facebook integration object

    onebit committed Jul 16, 2012
    Summary:
    The FBMyData facebook integration object is meant to provide a super
    lightweight integration experience for a core set of common needs. Apps
    that have heavier weight needs may choose to use FBMyData in addition to
    the more fundamental classes such as FBRequest and FBSession. However,
    the goal of this class is to provide sufficient functionality that
    some classes of application can get away with use of this class alone.
    The capabilities are:
    * notification of user logged in status
    * ability to handle (but not present) UX for connecting/disconnecting
    * ability to post a status
    * ability to post a photo
    * ability to fetch your info (name, fbid, etc.)
    * ability to fetch your friends list
    
    This diff also introduces an ultra-lightweight sample called "HiFacebook"
    
    Test Plan: Ran through supported features using HiFacebook
    
    Reviewers: clang, ayden
    
    Reviewed By: clang
    
    CC: msdkexp@, yariv, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D524684
    
    Task ID: 1188698
  3. @awzy

    Rename profile view controller userID to profileID

    awzy committed Jul 19, 2012
    Summary: Renamed userID to profileID in FBProfilePictureView
    
    Test Plan: Ran unit tests
    
    Reviewers: jacl, clang
    
    Reviewed By: jacl
    
    CC: bhiller, scottg
    
    Differential Revision: https://phabricator.fb.com/D525702
    
    Task ID: 1192590
  4. @clang13

    [ios-sdk] Add FBUserSettingsViewController and FBViewController class…

    clang13 committed Jul 17, 2012
    …es; pickers derive from FBViewController.
    
    Summary:
    FBViewController adds functionality for views which are presented modally, providing optional Done and Cancel
    buttons in a title toolbar. Views presented in a navigation controller may have a Done button, but no
    Cancel button (since the "back" button serves that purpose).
    
    FBUserSettingsViewController displays the current logged-in state of the user, and allows the user to log out
    and log in. The UI for this view controller is not yet final; in particular, it does not look good on iPad.
    Waiting for feedback from design before finalizing.
    
    Scrumptious uses FBUserSettingsViewController to let the user log out, but continues to use its custom view for
    logging in.
    
    Test Plan:
    - Ran Scrumptious
    - Ran new test app (not checked in) that exercises the view controllers in both a modal and a navigation context.
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D525096
    
    Task ID: 1188684
  5. @awzy

    Rename FBConnect to FacebookSDK

    awzy committed Jul 19, 2012
    Summary: Renamed FBConnect folder in main project to FacebookSDK. Also moved FBConnect.bundle into the Hackbook folder.
    
    Test Plan: Ran unit tests, hackbook sample
    
    Reviewers: jacl, clang
    
    Reviewed By: jacl
    
    CC: bhiller
    
    Differential Revision: https://phabricator.fb.com/D525738
    
    Task ID: 1188700
  6. @clang13

    [ios-sdk] Renamed FBiOSSDK.pmdoc to FacebookSDK.pmdoc

    clang13 committed Jul 19, 2012
    Summary:
    An earlier commit changed the build_distribution.sh script to use the new filename, but the actual file rename
    did not get picked up in that commit.
    
    Test Plan:
    - Ran build_distribution.sh
    
    Revert Plan:
    
    Reviewers: ayden, jacl
    
    Reviewed By: ayden
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D525320
    
    Blame Revision: D514982
Commits on Jul 19, 2012
  1. @clang13

    [ios-sdk] Don't attempt to send requests without a session in picker …

    clang13 committed Jul 16, 2012
    …view controllers.
    
    Summary:
    Both picker view controllers would attempt to send requests without a session. Since both of their
    request types require a session, this would always fail to produce any results. Added a check to
    skip sending a request if no session is specified.
    
    Test Plan:
    - Ran Scrumptious
    - Ran picker samples
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D520559
    
    Task ID: 1175259
Commits on Jul 18, 2012
  1. @clang13

    [ios-sdk] Fix KVO issues with [FBSession isOpen]

    clang13 committed Jul 17, 2012
    Summary:
    When isValid was changed to isOpen, the corresponding KVO-related code did not get changed.
    
    - Fixed string constant to be "isOpen" rather than "isValid"
    - Removed misleading headerdoc from two macros
    - Fixed initialization of changingIsOpen in transitionToState to be correct.
    
    Test Plan:
    - Ran new sample (not part of this checkin) and verified that notifications were being sent correctly
    in response to changingIsOpen, whereas before they were not.
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D522449
    
    Blame Revision: D477005
Commits on Jul 17, 2012
  1. @onebit

    Adds global notifications for the basic "active session on" and "acti…

    onebit committed Jul 17, 2012
    …ve session off" transitions
    
    Summary: For lightweight consumers (usually UX) these notifications can make it easy to track active session changes
    
    Test Plan: testing with follow-on diffs that consume this with various components
    
    Reviewers: clang
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D522148
    
    Task ID: 1188698
  2. @clang13

    [ios-sdk] Remove [NSURLConnection cancel] call from FBURLConnection t…

    clang13 committed Jul 16, 2012
    …hat caused leak on iOS < 6.0.
    
    Summary:
    Occasional memory leaks were observed on iOS 4.x and 5.x, and were tracked to the cancel call in FBURLConnection. It appears
    these were leaks in the system framework. Since the call wasn't strictly necessary and led to leaks, removing it.
    
    Test Plan:
    - Ran ProfilePicture sample under Instruments, observed no leak
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D521111
    
    Task ID: 1132284
  3. @clang13

    [ios-sdk] Removed string parameter from [FBSessionTokenCachingStrateg…

    clang13 committed Jul 13, 2012
    …y clearToken]
    
    Summary:
    The string parameter to this method was intended as an optimization to help implementations find
    the token to be deleted. However, since the intention is that only the current token would ever be
    deleted, they can store this data internally if they need to optimize for it, without requiring
    that all callers pay the tax of passing it in.
    
    Test Plan:
    - Ran unit tests
    - Ran SwitchUserSample (the only sample that used this method explicitly)
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D520450
    
    Task ID: 1188716
Commits on Jul 16, 2012
  1. @awzy

    Change framework name from FBiOSSDK to FacebookSDK

    awzy committed Jul 9, 2012
    Summary:
    Changed framework name from FBiOSSDK to FacebookSDK in the build scripts and sample apps.
    FBiOSSDKResources.bundle was also renamed to FacebookSDKResources.bundle, updated those references.
    
    Test Plan:
    - Ran samples
    - Ran unit tests
    
    Reviewers: jacl, mmarucheck, gregschechte, clang
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists, security-diffs@lists, yariv, bhiller, scottg
    
    Differential Revision: https://phabricator.fb.com/D514982
    
    Task ID: 1167996
  2. @onebit

    Fixes a bug in the pickers

    onebit committed Jul 16, 2012
    Summary:
    Change 94ba6df introduced a regression in the pickers that caused their data
    not to display; this fixes that
    
    Test Plan: tried the pickers in scrumptious
    
    Reviewers: clang, ayden
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D520551
    
    Task ID: 1193295
Commits on Jul 13, 2012
  1. @awzy

    Move the logging static methods in FBSession to public FBSettings class

    awzy committed Jul 9, 2012
    Summary: Create a new class FBSettings, and move to it the methods loggingBehavior and setLoggingBehaviour from FBSession.
    
    Test Plan: Ran unit tests
    
    Reviewers: clang, jacl, gregschechte, mmarucheck
    
    Reviewed By: gregschechte
    
    CC: yariv, bhiller
    
    Differential Revision: https://phabricator.fb.com/D514198
    
    Task ID: 1146322
  2. @gregschechter

    Explicitly account for Retina display in FBProfilePictureView

    gregschechter committed Jul 13, 2012
    Summary:
    Turns out that the dimensions returned for a view's bounds don't change under Retina display.  (Apparently due to apps breaking all over the place when Retina was introduced.)
    
    So, we need to calculate ourselves when figuring out what size profile picture to request
    
    Test Plan: My box - retina & non-retina, on ProfilePictureViewer
    
    Reviewers: clang, jacl, mmarucheck
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D519182
Commits on Jul 12, 2012
  1. @onebit

    Fixes typo in docs

    onebit committed Jul 11, 2012
    Summary: per title
    
    Test Plan: n/a
    
    Reviewers: clang, caabernathy
    
    Reviewed By: caabernathy
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D517773
    
    Task ID: 1011836
  2. @gregschechter

    Updated FBProfilePictureView to use hi-res square image Graph API

    gregschechter committed Jul 9, 2012
    Summary:
    The Graph API for retrieving hi-res square profile pictures is now on, and this change modifies the FBProfilePictureView to use it.
    
    - For the logic change here, see FBProfilePictureView.m
    - Changed the default cropping to square, since with hi-res square, the quality is typically just as good, and non-square is very hard to reason about as someone using the control (aspect ratio is different for every user).
    - Removed all but the largest non-square blank profile, and updated the square one to be bigger.  No need to carry the smaller versions as these larger ones scale down fine.
    - Updated ProfilePictureSample to include a "none" option that results in showing the blank profile.
    - Updated HelloFacebookSample to make both profile picture views square.
    
    Note that when you use this sample or control, some of the square images will still be 50x50.  That's because there's a migration job starting today (7/10) that should take about a week to re-gen larger square profiles for users who haven't updated their profile in more than a year.
    
    Task: #1113853
    
    Test Plan: Samples on iPhone/iPad.  In particular used ProfilePictureSample to run through lots of combinations.
    
    Reviewers: clang, jacl, ayden, mmarucheck
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D515828
Commits on Jul 11, 2012
  1. @onebit

    Some memory related cleanup

    onebit committed Jul 10, 2012
    Summary: Did some review and found a few issues with memory management in the view controllers.
    
    Test Plan: Code review
    
    Reviewers: clang, gregschechte, mmarucheck
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D516460
    
    Task ID: 1011836
  2. @clang13

    [ios-sdk] Fix bug in paging loader that led to multiple activity indi…

    clang13 committed Jul 10, 2012
    …cators in friend picker.
    
    Summary:
    FBGraphObjectPagingLoader was setting a dataNeededDelegate on its data source even if it was not in the
    AsNeeded paging mode. This was fooling the data source into thinking it should display a spinner in the
    bottom-most table cell to indicate data was being fetched. Controls that aren't in AsNeeded mode may have
    other UI to indicate when they load data (as friend picker does), so this spinner was redundant.
    
    Fixed FBGraphObjectPagingLoader to only set a dataNeededDelegate if it actually should; in turn, this pointed
    out that pagingMode should not be a writable property on the object, as there is little hope of things working
    correctly if the pagingMode is changed during the lifetime of an object. Changed it into a readonly property
    set at init-time.
    
    Test Plan:
    - Ran FriendPickerSample
    - Ran PlacesPickerSample
    - Ran Scrumptious
    - Ran HelloFacebook
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D516326
Commits on Jul 10, 2012
  1. @onebit

    Update to the root readme, couple string literal changes

    onebit committed Jul 10, 2012
    Summary:
    1) simplifies the readme, and points users to Hello Facebook
    2) Uses "Log In" and "Log Out" in FBLoginView
    
    Test Plan: Built & ran
    
    Reviewers: clang, gregschechte
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D515487
    
    Task ID: 1011836
  2. @onebit

    Minor cleanup to account for some quirks in the iOS6 preview support

    onebit committed Jul 9, 2012
    Summary:
    1) comments-out a couple of lines of valid code in the samples in order to
    avoid exercising a bug in the iOS preview support -- well address before production
    2) introduces a protocol that we use to handle warnings in late-bound calls
    
    Test Plan: compiled and ran samples
    
    Reviewers: clang, gregschechte
    
    Reviewed By: clang
    
    CC: ekoneil, msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D515035
    
    Task ID: 1011836
Commits on Jul 9, 2012
  1. @onebit

    Small doc change and turn on iOS 6 build support with 5.0 compiler

    onebit committed Jul 9, 2012
    Summary: Per title
    
    Test Plan: Confirmed build
    
    Reviewers: gregschechte, clang
    
    Reviewed By: clang
    
    CC: ekoneil, msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D514185
    
    Task ID: 1011836
  2. @clang13

    [ios-sdk] More Scrumptious cleanup.

    clang13 committed Jul 6, 2012
    Summary:
    In working through the tutorial and recent FBSession changes, I found a few more places where
    Scrumptious could be cleaned up. Also fixed a unit test that wasn't ever actually asserting
    anything succeeded.
    
    Test Plan:
    - Ran Scrumptious
    - Ran unit tests
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D513407
Commits on Jul 8, 2012
  1. @gregschechter

    Add initWithPermissions: method for FBLoginView

    gregschechter committed Jul 7, 2012
    Summary:
    Need a way to pass permissions into FBLoginView.  The MyProfile sample is broken without it.  This adds a new init method to do that.
    
    Not adding a property since the perms can be accessed off of FBSession.activeSession.permission.  Similarly, re-authorization with new permission set can be done off of that as well.  So this is really just about the initial construction.
    
    Modified MyProfile to use.
    
    Test Plan: Ran MyProfile sample after deleting from my simulator and from my FB app list on the web.  Re-auth'd and succeeded in updating my status from the app.  That's what wasn't working before.
    
    Reviewers: jacl, clang
    
    Reviewed By: jacl
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D513943
    
    Blame Revision: D509506
Commits on Jul 7, 2012
  1. @onebit

    Embraces Facebook Login terminology

    onebit committed Jul 6, 2012
    Summary:
    Title pretty much says it all, a few enum changes, variable name changes and
    comment changes to embrace the new terms for things.
    
    Test Plan: Build and run a sample or two; particularly switch user
    
    Reviewers: clang, gregschechte, ayden, mmarucheck
    
    Reviewed By: gregschechte
    
    CC: ekoneil, msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D513837
    
    Task ID: 1170930, 1011836
Commits on Jul 6, 2012
  1. @gregschechter

    Update FBLoginView to include a button with Login/Logout

    gregschechter committed Jul 6, 2012
    Summary:
    Add a simple button with the Login/Logout text to the FBLoginView.  This lets us remove text in samples that use this.
    
    Note that this presentation of the FBLoginView will change post-beta to be much more FB-branded, and this is just intended to tide us over.
    
    Test Plan: MyProfile sample on iPhone/iPad simulators
    
    Reviewers: jacl, clang
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D513372
  2. @onebit

    Adds preview support for iOS 6 integrated auth to FBSession

    onebit committed Jul 5, 2012
    Summary:
    This diff does the following things -
      1. Introduces a define that will compile-in preview support for iOS 6 integration
      2. Updates the samples to include the Accounts package
      3. Minor tweaks to two of the samples
    
    Some notes -
      * The stability of the iOS 6 integration is not 100%, so the code includes some
        odd defensive measures, including adding a permission when the list is nil, etc.
      * The integration of iOS 6 is still provisional and there are known changes, such
        as support for integrated caching, which are not present here
    
    Test Plan: Ran each sample with integrated and non integrated auth, significant whitebox testing as well, ran a subset of the samples using 4.3 simulator to confirm fallback behavior
    
    Reviewers: clang, mmarucheck, gregschechte
    
    Reviewed By: clang
    
    CC: msdkexp@
    
    Differential Revision: https://phabricator.fb.com/D513350
    
    Task ID: 1142879
Commits on Jul 3, 2012
  1. @awzy

    Add friendly wrapping and default session behavior to FBRequest

    awzy committed Jun 29, 2012
    Summary:
    Change the default session behavior of FBRequest to use the activeSession, if it is open;
    removes session as an argument from the public functions of FBRequest.
    Fixed the samples and tests to use the new public functions.
    
    Test Plan: Ran each of the sample apps
    
    Reviewers: clang, jacl, gregschechte, mmarucheck
    
    Reviewed By: clang
    
    CC: platform-diffs@lists, bhiller
    
    Differential Revision: https://phabricator.fb.com/D510519
    
    Task ID: 1145396
  2. @onebit

    Adds FBLoginView

    onebit committed Jun 27, 2012
    Summary:
    This diff -
    1) adds the FBLoginView
    2) updates My Profile sample to use it
    3) refines activeSession logic
    
    Test Plan: updated My Profile to use the login view, and manual tested
    
    Reviewers: gregschechte, clang, mmarucheck, ayden
    
    Reviewed By: gregschechte
    
    CC: ekoneil, yariv
    
    Differential Revision: https://phabricator.fb.com/D509506
    
    Task ID: 1097711
  3. @clang13

    [ios-sdk] Some miscellaneous cleanup.

    clang13 committed Jun 21, 2012
    Summary:
    Fixed a couple places where we were defining outdated parameters that were once used but
    now always have the same value (or where we are now ignoring the value). Couple other
    trivial fixes.
    
    Test Plan:
    - Ran unit tests
    
    Revert Plan:
    
    Reviewers: jacl, mmarucheck, gregschechte, ayden
    
    Reviewed By: gregschechte
    
    CC: msdkexp@, platform-diffs@lists
    
    Differential Revision: https://phabricator.fb.com/D510261
Something went wrong with that request. Please try again.