Skip to content

Upgraded to SBJson 3.1.1 #481

Closed
wants to merge 2 commits into from

7 participants

@kylefleming

Considering the frequent conflicts with Facebook-iOS-SDK's SBJson and other libraries, and given the rise of CocoaPods, we should consider upgrading Facebook-iOS-SDK's internal SBJson to a modern version (or using JSONKit).

In this pull request, I've upgraded SBJson from v2.2.3 to v3.1.1 for Facebook-iOS-SDK v3.0.7.

Reference:
Facebook-iOS-SDK in CocoaPods
See #296, #338, #419, #431, #438, #443, #455, #467, #471 for previous discussions on the issue.

@dkuhnke
@pj4533
pj4533 commented Aug 24, 2012

+1

Related, this bug with conflicting JSONs has hit me, and few others. Details here:

http://developers.facebook.com/bugs/202230616574138

Not sure if your pull request would fix it, but I am gonna try it and see.

@pj4533
pj4533 commented Aug 24, 2012

btw, just verified that this pull request fixes the bug I mentioned above.

@aporat
aporat commented Aug 29, 2012

:+1:

@kylefleming

SBJson 3.1.1 uses ARC while Facebook-iOS-SDK 3.0.7 is non-ARC. @facebook, if this is a reason you're reluctant to merge in, use SBJson 3.0.x instead.

@jonkean
jonkean commented May 2, 2013

This is obsolete and request should be closed

@kylefleming kylefleming closed this May 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.